Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not default window size #3623

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Do not default window size #3623

merged 4 commits into from
Oct 15, 2024

Conversation

AlanGriffiths
Copy link
Collaborator

@AlanGriffiths AlanGriffiths commented Oct 7, 2024 •
edited
Loading

Stop pretending (mostly) that windows we don't know the size of are 640x480, 100x100, or 1x1.

@AlanGriffiths AlanGriffiths requested a review from a team as a code owner October 7, 2024 11:36
@AlanGriffiths AlanGriffiths marked this pull request as draft October 8, 2024 11:21
@AlanGriffiths
Copy link
Collaborator Author

Converted to draft until test failures are resolved

@AlanGriffiths AlanGriffiths force-pushed the do-not-default-specified-window-size branch from 2386ff0 to d715f56 Compare October 10, 2024 11:23
@AlanGriffiths
Copy link
Collaborator Author

@Saviq d715f56 fixes some UB - is that worth a cherry-pick to 2.18.3?

@Saviq
Copy link
Collaborator

Saviq commented Oct 10, 2024

@Saviq d715f56 fixes some UB - is that worth a cherry-pick to 2.18.3?

Since we weren't planning to rebuild snaps based on 2.18.3, I don't think so.

@AlanGriffiths
Copy link
Collaborator Author

Since we weren't planning to rebuild snaps based on 2.18.3, I don't think so.

NM, this PR introduced the UB anyway, so irrelevant

@AlanGriffiths AlanGriffiths marked this pull request as ready for review October 10, 2024 11:35
tarek-y-ismail
tarek-y-ismail requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@tarek-y-ismail tarek-y-ismail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested both bomber with miral-shell and kgx with miral-kiosk and they work as expected 👍 . Just need to rebase on main to get the docs checks to pass and we're all good to merge.

@AlanGriffiths
Copy link
Collaborator Author

Just need to rebase on main to get the docs checks to pass and we're all good to merge.

AFAICS docs "pass" is not required for merge.

@tarek-y-ismail tarek-y-ismail added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@AlanGriffiths
Copy link
Collaborator Author

AFAICS docs "pass" is not required for merge.

OTOH we do need the asan builds to pass.

[aside] I wonder why the asan errors have manifested now: the code involved isn't new.

@tarek-y-ismail
Copy link
Contributor

Yeah I'm working on those right now. I'm also not sure why the errors popped up now.

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@Saviq Saviq added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@AlanGriffiths AlanGriffiths added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@AlanGriffiths AlanGriffiths added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@tarek-y-ismail tarek-y-ismail added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit c8aa9df Oct 15, 2024
51 of 62 checks passed
@tarek-y-ismail tarek-y-ismail deleted the do-not-default-specified-window-size branch October 15, 2024 15:01
@AlanGriffiths AlanGriffiths mentioned this pull request Oct 26, 2024
Closed
This was referenced Nov 28, 2024
Merged
Closed
github-merge-queue bot pushed a commit that referenced this pull request Dec 3, 2024
@Saviq
Release 2.19.0 (#3686)
699dcde 
# rc1

  * New upstream release 2.19.0

    - ABI summary:
      . miral ABI unchanged at 7
      . mircommon ABI unchanged at 10
      . mircore ABI unchanged at 2
      . miroil ABI unchanged at 5
      . mirplatform ABI bumped to 30
      . mirserver ABI bumped to 61
      . mirwayland ABI unchanged at 5
      . mirplatformgraphics ABI unchanged at 22
      . mirinputplatform ABI unchanged at 9

    - Enhancements:
. [x11-kiosk] defer fullscreening of applications until they are placed
once (#3670)
. [x11-kiosk] Ensure windows are placed and repainted on X11 "CONFIGURE"
(#3619)
      . [x11-kiosk] change enable-x11 default to true
      . Initial atomic-kms platform
      . [Wayland] Add support for xdg_activation_v1 (#3639)
      . Do not default window size (especially to weird values) (#3623)
. DesktopFileManager::resolve_app_id no longer returns an app id with a
.desktop file suffix (Fixes #3608)
. [Configuration] Split options into global and per-module configuration
(#3590)

    - Bugs fixed:
      . Ensure we always send an initial output enter (#3680)
      . Fix stuck-frame-after-mode-switch bug (#3673)
. Fix rendering of resized XWayland applications with client side
decorations (#3587)
      . Aspect ratios shouldn't contain zero (Fixes: #3663)
      . Use PkgConfig to find development headers (#3661)
. Fix the inotify event handling in
ReloadingYamlFileDisplayConfig::auto_reload() (#3636)
. The `miral::ConfigFile` "Watcher" can be destroyed before the main
loop (Fixes: #3612)
      . [xwayland] Don't allow clients to place X11 windows (#3622)
. Surfaces track scale changes on outputs they appear on. (Fixes: #3552)
      . New attached windows need to be placed (#3676)

----
[Test
Plan](https://canonical-mir.readthedocs-hosted.com/latest/how-to/how-to-test-mir-for-a-release/)

### Platforms
|| 24.04 | 24.10 |
|-|-|-|
| gbm-kms |@AlanGriffiths|@AlanGriffiths|
| atomic-kms |@AlanGriffiths|@AlanGriffiths|
| eglstream-kms |@tarek-y-ismail||
| eglstream-kms + gbm-kms hybrid |@tarek-y-ismail||
| x11 |@AlanGriffiths|@AlanGriffiths|
| wayland |@AlanGriffiths|@AlanGriffiths|
| virtual |@AlanGriffiths|@AlanGriffiths|

### Console Providers
|| 24.04 | 24.10 |
|-|-|-|
| vt |@AlanGriffiths|@AlanGriffiths|
| logind |@AlanGriffiths|@AlanGriffiths|
| minimal |@AlanGriffiths||

### Window Manager Examples
|| 24.04 | 24.10 |
|-|-|-|
| --window-manager=floating |@AlanGriffiths|@AlanGriffiths|
| --window-manager=tiling |@AlanGriffiths||
| -kiosk |@AlanGriffiths||
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarek-y-ismail tarek-y-ismail tarek-y-ismail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanGriffiths @Saviq @tarek-y-ismail