Ensure windows are placed and repainted on X11 "CONFIGURE" #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanGriffiths
force-pushed
the
fix-x11-kiosk
branch
from
cbdab5c to
f24c49c
Compare
AlanGriffiths
force-pushed
the
fix-x11-kiosk
branch
from
05aa722 to
6d165fd
Compare
AlanGriffiths
changed the title
Saviq
approved these changes
Oct 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Saviq
pushed a commit
that referenced
this pull request
Oct 7, 2024
We are 1. Leaking the X11 `CONFIGURE` placement through (when we should be ignoring it); and, 2. Not properly placing windows that `CONFIGURE` to fullscreen when they are already forced to be fullscreen. This works around these problems in the least invasive way.
Merged
AlanGriffiths
added a commit
that referenced
this pull request
Oct 14, 2024
## Enhancements: - Ensure windows are placed and repainted on X11 "CONFIGURE" #3619 --------- Co-authored-by: Alan Griffiths <[email protected]>
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
# rc1
* New upstream release 2.19.0
- ABI summary:
. miral ABI unchanged at 7
. mircommon ABI unchanged at 10
. mircore ABI unchanged at 2
. miroil ABI unchanged at 5
. mirplatform ABI bumped to 30
. mirserver ABI bumped to 61
. mirwayland ABI unchanged at 5
. mirplatformgraphics ABI unchanged at 22
. mirinputplatform ABI unchanged at 9
- Enhancements:
. [x11-kiosk] defer fullscreening of applications until they are placed
once (#3670)
. [x11-kiosk] Ensure windows are placed and repainted on X11 "CONFIGURE"
(#3619)
. [x11-kiosk] change enable-x11 default to true
. Initial atomic-kms platform
. [Wayland] Add support for xdg_activation_v1 (#3639)
. Do not default window size (especially to weird values) (#3623)
. DesktopFileManager::resolve_app_id no longer returns an app id with a
.desktop file suffix (Fixes #3608)
. [Configuration] Split options into global and per-module configuration
(#3590)
- Bugs fixed:
. Ensure we always send an initial output enter (#3680)
. Fix stuck-frame-after-mode-switch bug (#3673)
. Fix rendering of resized XWayland applications with client side
decorations (#3587)
. Aspect ratios shouldn't contain zero (Fixes: #3663)
. Use PkgConfig to find development headers (#3661)
. Fix the inotify event handling in
ReloadingYamlFileDisplayConfig::auto_reload() (#3636)
. The `miral::ConfigFile` "Watcher" can be destroyed before the main
loop (Fixes: #3612)
. [xwayland] Don't allow clients to place X11 windows (#3622)
. Surfaces track scale changes on outputs they appear on. (Fixes: #3552)
. New attached windows need to be placed (#3676)
----
[Test
Plan](https://canonical-mir.readthedocs-hosted.com/latest/how-to/how-to-test-mir-for-a-release/)
### Platforms
|| 24.04 | 24.10 |
|-|-|-|
| gbm-kms |@AlanGriffiths|@AlanGriffiths|
| atomic-kms |@AlanGriffiths|@AlanGriffiths|
| eglstream-kms |@tarek-y-ismail||
| eglstream-kms + gbm-kms hybrid |@tarek-y-ismail||
| x11 |@AlanGriffiths|@AlanGriffiths|
| wayland |@AlanGriffiths|@AlanGriffiths|
| virtual |@AlanGriffiths|@AlanGriffiths|
### Console Providers
|| 24.04 | 24.10 |
|-|-|-|
| vt |@AlanGriffiths|@AlanGriffiths|
| logind |@AlanGriffiths|@AlanGriffiths|
| minimal |@AlanGriffiths||
### Window Manager Examples
|| 24.04 | 24.10 |
|-|-|-|
| --window-manager=floating |@AlanGriffiths|@AlanGriffiths|
| --window-manager=tiling |@AlanGriffiths||
| -kiosk |@AlanGriffiths||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are
CONFIGUREplacement through (when we should be ignoring it); and,CONFIGUREto fullscreen when they are already forced to be fullscreen.This works around these problems in the least invasive way.