feature: users can specify an app id for the wayland surface when running on the wayland platform #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning on the wayland platform
Saviq
reviewed
Sep 25, 2024
We don't have a |
That's what I mean - should we add it, in one go? |
Sure! |
Saviq
reviewed
Sep 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
…ning on the wayland platform (#3614) ## What's new? - Added the `--wayland-surface-app-id=<APP_ID>` option for the wayland platform that, when set, will call [xdg_top_level::set_app_id](https://wayland.app/protocols/xdg-shell#xdg_toplevel:request:set_app_id) with the value `APP_ID` - Added the `--wayland-surface-title=<TITLE>` option for the wayland platform that, when set, will call [xdg_top_level::set_title](https://wayland.app/protocols/xdg-shell#xdg_toplevel:request:set_title) with the value `TITLE`
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Saviq
added a commit
that referenced
this pull request
Sep 26, 2024
…ning on the wayland platform (#3614) ## What's new? - Added the `--wayland-surface-app-id=<APP_ID>` option for the wayland platform that, when set, will call [xdg_top_level::set_app_id](https://wayland.app/protocols/xdg-shell#xdg_toplevel:request:set_app_id) with the value `APP_ID` - Added the `--wayland-surface-title=<TITLE>` option for the wayland platform that, when set, will call [xdg_top_level::set_title](https://wayland.app/protocols/xdg-shell#xdg_toplevel:request:set_title) with the value `TITLE`
Saviq
added a commit
that referenced
this pull request
Sep 27, 2024
Enhancements: . Allow to specify an app id for when running on the wayland platform #3614 Bugs fixed: . SIGSEGV on input device disconnection #3601 . Frame fails to enforce fullscreen on wpe-webkit-mir-kiosk #3600 . Chromium unmaximises when focus is lost #3592 . Apps constantly resizing #3573 . Our fork/exec spawning is unsafe #3494 . Revert "Fix random leak" #3609 . Smoke tests are failing #3610
Saviq
added a commit
that referenced
this pull request
Sep 27, 2024
Enhancements: . Allow to specify an app id for when running on the wayland platform #3614 Bugs fixed: . SIGSEGV on input device disconnection #3601 . Frame fails to enforce fullscreen on wpe-webkit-mir-kiosk #3600 . Chromium unmaximises when focus is lost #3592 . Apps constantly resizing #3573 . Our fork/exec spawning is unsafe #3494 . Revert "Fix random leak" #3609 . Smoke tests are failing #3610
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
--wayland-surface-app-id=<APP_ID>option for the wayland platform that, when set, will call xdg_top_level::set_app_id with the valueAPP_ID--wayland-surface-title=<TITLE>option for the wayland platform that, when set, will call xdg_top_level::set_title with the valueTITLE