Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.18.2 #3603

Merged
merged 9 commits into from
Sep 30, 2024
Merged

Release 2.18.2 #3603

merged 9 commits into from
Sep 30, 2024

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Sep 19, 2024 •
edited
Loading

@Saviq
Less flaky device handling (#3602)
c439378 
Fix some dubious assumption in DefaultInputDeviceHub.

Fixes: #3601
@AlanGriffiths
Copy link
Collaborator

We should also consider these for cherry-pick:

@Saviq
Copy link
Collaborator Author

Saviq commented Sep 23, 2024

We should also consider these for cherry-pick:

Done.

@AlanGriffiths
Copy link
Collaborator

I've run through the things that should be fixed. I think we can mark this ready

@Saviq
Copy link
Collaborator Author

Saviq commented Sep 24, 2024

I've run through the things that should be fixed. I think we can mark this ready

I'm just looking into the last issue floating about (X11 dialog sizing).

@Saviq Saviq marked this pull request as ready for review September 24, 2024 12:18
@Saviq Saviq requested a review from a team as a code owner September 24, 2024 12:18
@Saviq
Copy link
Collaborator Author

Saviq commented Sep 24, 2024

I'm just looking into the last issue floating about (X11 dialog sizing).

That seems to be a problem with mir-x11-kiosk, not Mir itself.

Saviq and others added 2 commits September 25, 2024 16:42
@Saviq
Revert "Fix random leak" (#3609)
87c20fb 
Fixes x11-kiosk crash when running on `mir:wayland`

(It looks like any use if the `mir:wayland` platform would fail)
@AlanGriffiths @Saviq
Do not extend the InputDeviceHub lifetime beyond teardown (#3611)
0a3a87b 
Fixes: #3610
@Saviq Saviq force-pushed the release/2.18 branch 2 times, most recently from b1c5650 to 633c9e8 Compare September 25, 2024 14:44
@Saviq
feature: users can specify an app id for the wayland surface when run…
e8caf6f 
…ning on the wayland platform (#3614)

## What's new?
- Added the `--wayland-surface-app-id=<APP_ID>` option for the wayland
platform that, when set, will call
[xdg_top_level::set_app_id](https://wayland.app/protocols/xdg-shell#xdg_toplevel:request:set_app_id)
with the value `APP_ID`
- Added the `--wayland-surface-title=<TITLE>` option for the wayland
platform that, when set, will call
[xdg_top_level::set_title](https://wayland.app/protocols/xdg-shell#xdg_toplevel:request:set_title)
with the value `TITLE`
@Saviq Saviq force-pushed the release/2.18 branch 2 times, most recently from 51cf450 to 24a3a18 Compare September 27, 2024 18:21
Saviq and others added 2 commits September 27, 2024 20:53
@Saviq
examples/miral-shell: Use generic logos for example applications (#3617)
1167b33 
These are some self-created simple crafted logos for miral-shell to
replace the usage of the Ubuntu logo to make Mir examples easier to
ship.

Thanks @Conan-Kudo!
@Saviq
Bugfix release 2.18.2
824d0ef 
Enhancements:
. Allow to specify an app id for when running on the wayland platform #3614

Bugs fixed:
. SIGSEGV on input device disconnection #3601
. Frame fails to enforce fullscreen on wpe-webkit-mir-kiosk #3600
. Chromium unmaximises when focus is lost #3592
. Apps constantly resizing #3573
. Our fork/exec spawning is unsafe #3494
. Revert "Fix random leak" #3609
. Smoke tests are failing #3610
@Saviq Saviq changed the title Release 2.18.1 Release 2.18.2 Sep 27, 2024
@Saviq Saviq enabled auto-merge September 30, 2024 08:53
@Saviq Saviq requested a review from AlanGriffiths September 30, 2024 08:53
AlanGriffiths
AlanGriffiths approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit

@Saviq Saviq added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 4d066de Sep 30, 2024
60 checks passed
@Saviq Saviq deleted the release/2.18 branch September 30, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saviq @AlanGriffiths