Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix random leak" #3609

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Revert "Fix random leak" #3609

merged 1 commit into from
Sep 24, 2024

Conversation

AlanGriffiths
Copy link
Collaborator

@AlanGriffiths AlanGriffiths commented Sep 24, 2024

Fixes x11-kiosk crash when running on mir:wayland

(It looks like any use if the mir:wayland platform would fail)

This reverts commit 864371b.
@AlanGriffiths AlanGriffiths requested a review from a team as a code owner September 24, 2024 16:29
@AlanGriffiths
Copy link
Collaborator Author

The original commit is clearly wrong. filename is overwritten and then free()d a few lines later

@AlanGriffiths
Copy link
Collaborator Author

@Saviq this is one to cherry-pick into 2.18.1

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

@Saviq Saviq enabled auto-merge September 24, 2024 16:49
@Saviq Saviq added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 6d79e7e Sep 24, 2024
37 checks passed
@Saviq Saviq deleted the fix-x11-kiosk branch September 24, 2024 22:28
Saviq added a commit that referenced this pull request Sep 25, 2024
Fixes x11-kiosk crash when running on `mir:wayland`

(It looks like any use if the `mir:wayland` platform would fail)
Saviq added a commit that referenced this pull request Sep 25, 2024
Fixes x11-kiosk crash when running on `mir:wayland`

(It looks like any use if the `mir:wayland` platform would fail)
Saviq added a commit that referenced this pull request Sep 25, 2024
Fixes x11-kiosk crash when running on `mir:wayland`

(It looks like any use if the `mir:wayland` platform would fail)
@Saviq Saviq mentioned this pull request Sep 25, 2024
Saviq added a commit that referenced this pull request Sep 27, 2024
Enhancements:
. Allow to specify an app id for when running on the wayland platform #3614

Bugs fixed:
. SIGSEGV on input device disconnection #3601
. Frame fails to enforce fullscreen on wpe-webkit-mir-kiosk #3600
. Chromium unmaximises when focus is lost #3592
. Apps constantly resizing #3573
. Our fork/exec spawning is unsafe #3494
. Revert "Fix random leak" #3609
. Smoke tests are failing #3610
Saviq added a commit that referenced this pull request Sep 27, 2024
Enhancements:
. Allow to specify an app id for when running on the wayland platform #3614

Bugs fixed:
. SIGSEGV on input device disconnection #3601
. Frame fails to enforce fullscreen on wpe-webkit-mir-kiosk #3600
. Chromium unmaximises when focus is lost #3592
. Apps constantly resizing #3573
. Our fork/exec spawning is unsafe #3494
. Revert "Fix random leak" #3609
. Smoke tests are failing #3610
github-merge-queue bot pushed a commit that referenced this pull request Sep 30, 2024
>  Release 2.18.2
>
>  Enhancements:
>  - #3614
>  - #3617
>
>  Bugs fixed:
>   - #3601
>   - #3600
>   - #3592
>   - #3573
>   - #3494
>   - #3609
>   - #3610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants