-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fix random leak" #3609
Merged
Merged
Revert "Fix random leak" #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 864371b.
The original commit is clearly wrong. |
@Saviq this is one to cherry-pick into 2.18.1 |
Saviq
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops.
Saviq
added a commit
that referenced
this pull request
Sep 25, 2024
Fixes x11-kiosk crash when running on `mir:wayland` (It looks like any use if the `mir:wayland` platform would fail)
Saviq
added a commit
that referenced
this pull request
Sep 25, 2024
Fixes x11-kiosk crash when running on `mir:wayland` (It looks like any use if the `mir:wayland` platform would fail)
Saviq
added a commit
that referenced
this pull request
Sep 25, 2024
Fixes x11-kiosk crash when running on `mir:wayland` (It looks like any use if the `mir:wayland` platform would fail)
Merged
Saviq
added a commit
that referenced
this pull request
Sep 27, 2024
Enhancements: . Allow to specify an app id for when running on the wayland platform #3614 Bugs fixed: . SIGSEGV on input device disconnection #3601 . Frame fails to enforce fullscreen on wpe-webkit-mir-kiosk #3600 . Chromium unmaximises when focus is lost #3592 . Apps constantly resizing #3573 . Our fork/exec spawning is unsafe #3494 . Revert "Fix random leak" #3609 . Smoke tests are failing #3610
Saviq
added a commit
that referenced
this pull request
Sep 27, 2024
Enhancements: . Allow to specify an app id for when running on the wayland platform #3614 Bugs fixed: . SIGSEGV on input device disconnection #3601 . Frame fails to enforce fullscreen on wpe-webkit-mir-kiosk #3600 . Chromium unmaximises when focus is lost #3592 . Apps constantly resizing #3573 . Our fork/exec spawning is unsafe #3494 . Revert "Fix random leak" #3609 . Smoke tests are failing #3610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes x11-kiosk crash when running on
mir:wayland
(It looks like any use if the
mir:wayland
platform would fail)