-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Np add library level metrics tests #1348
Conversation
Remember to squash merge! |
🔍Changelog Validation Results:
|
🔍Version Validation Results:
|
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
The smart tests are currently failing because there are no library_metrics.csv truth files for paired tag, optimus, or multiome. I created a new branch of truth (https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/81636/console) and re-ran the code from my branch against this new truth. The tests pass here: I wanted to also test and make sure the test will fail if the library_metrics.csv did not match the truth, so I manually edited the truth library_metrics.csv so it would not match my test library_metrics.csv. The test fails in the correct way here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
Adding a task to Multiome, Optimus, and PairedTag to test library_metrics
Checklist
If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP documentation team by tagging either @ekiernan or @kayleemathews in a comment on this PR.