Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Np add library level metrics tests #1348

Merged
merged 11 commits into from
Aug 1, 2024

Conversation

nikellepetrillo
Copy link
Contributor

Description

Adding a task to Multiome, Optimus, and PairedTag to test library_metrics


Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP documentation team by tagging either @ekiernan or @kayleemathews in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@nikellepetrillo
Copy link
Contributor Author

The smart tests are currently failing because there are no library_metrics.csv truth files for paired tag, optimus, or multiome.

I created a new branch of truth (https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/81636/console) and re-ran the code from my branch against this new truth. The tests pass here:
https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/81637/console

I wanted to also test and make sure the test will fail if the library_metrics.csv did not match the truth, so I manually edited the truth library_metrics.csv so it would not match my test library_metrics.csv. The test fails in the correct way here:
https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/81638/

Copy link
Contributor

@kevinpalis kevinpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nikellepetrillo nikellepetrillo merged commit a899f97 into develop Aug 1, 2024
10 of 11 checks passed
@nikellepetrillo nikellepetrillo deleted the np_add_Library-level-metrics-tests branch August 1, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants