Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): fix indentation to remove duplications #6626

Merged
merged 3 commits into from
Dec 8, 2024
+5 −0
Merged

fix(secrets): fix indentation to remove duplications #6626

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60fb125
fix indentation
RabeaZr Jul 31, 2024
b3b8592
empty
RabeaZr Jul 31, 2024
0f265f0
Merge branch 'main' into remove-indentation
ChananM Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions checkov/secrets/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,11 +248,11 @@ def run(
added_by = enriched_potential_secret.get('added_by') or ''
removed_date = enriched_potential_secret.get('removed_date') or ''
added_date = enriched_potential_secret.get('added_date') or ''
# run over secret key
if isinstance(secret.secret_value, str) and secret.secret_value:
stripped = secret.secret_value.strip(',"')
if stripped != secret.secret_value:
secret_key = f'{key}_{secret.line_number}_{PotentialSecret.hash_secret(stripped)}'
# run over secret key
if isinstance(secret.secret_value, str) and secret.secret_value:
stripped = secret.secret_value.strip(',";\'')
if stripped != secret.secret_value:
secret_key = f'{key}_{secret.line_number}_{PotentialSecret.hash_secret(stripped)}'
if secret.secret_value and is_potential_uuid(secret.secret_value) and secret.check_id not in secrets_in_uuid_form:
logging.info(
f"Removing secret due to UUID filtering: {PotentialSecret.hash_secret(secret.secret_value)}")
Expand Down
5 changes: 5 additions & 0 deletions tests/secrets/test_prioritise_secrets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ def test_no_removal_other_check_id(self):
self.assertFalse(result)
self.assertIn('key3', self.secret_records)

def test_no_removal_of_first_check_id(self):
result = Runner._prioritise_secrets(self.secret_records, 'key1', 'CKV_SECRET_80')
self.assertFalse(result)
self.assertIn('key1', self.secret_records)


if __name__ == '__main__':
unittest.main()
Loading