Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): fix indentation to remove duplications #6626

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

RabeaZr
Copy link
Contributor

@RabeaZr RabeaZr commented Jul 31, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Adds a new test case test_no_removal_of_first_check_id to ensure that the Runner._prioritise_secrets method does not remove the first check ID.

TopicDetails
Secret Prioritization Enhances the test suite for the Runner._prioritise_secrets method to verify its behavior with the first check ID.
Modified files (1)
  • tests/secrets/test_prioritise_secrets.py
Latest Contributors(1)
UserCommitDate
57212002+ChanochShayne...feat-secrets-add-CKV_S...July 25, 2024
This pull request is reviewed by Baz. Join @RabeaZr and the rest of your team on (Baz).

@RabeaZr RabeaZr temporarily deployed to scan-security July 31, 2024 08:53 — with GitHub Actions Inactive
@RabeaZr RabeaZr temporarily deployed to scan-security July 31, 2024 08:57 — with GitHub Actions Inactive
@pazbechor pazbechor self-requested a review July 31, 2024 09:14
@rotemavni rotemavni merged commit 16f9543 into main Dec 8, 2024
38 checks passed
@rotemavni rotemavni deleted the remove-indentation branch December 8, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants