Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add task listeners for Zeebe #1088

Merged
merged 3 commits into from
Nov 18, 2024
Merged

feat: add task listeners for Zeebe #1088

merged 3 commits into from
Nov 18, 2024

Conversation

misiekhardcore
Copy link
Contributor

@misiekhardcore misiekhardcore commented Nov 7, 2024

related to camunda/camunda-modeler#4590

Proposed Changes

Add task listener to user task.

  • task listeners are allowed only for zeebe user tasks
  • event can be set to complete or assignment
  • listener type and number of retries can be set
Screencast.from.2024-11-07.13-56-29.webm

can be tested with npm start on the branch

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 7, 2024
@misiekhardcore misiekhardcore marked this pull request as draft November 7, 2024 11:16
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Nov 7, 2024
@misiekhardcore misiekhardcore force-pushed the user-task-listener branch 2 times, most recently from 4981e32 to 5c54e29 Compare November 7, 2024 15:58
@misiekhardcore misiekhardcore force-pushed the user-task-listener branch 2 times, most recently from b2f4b8f to 0023dc5 Compare November 14, 2024 15:05
@misiekhardcore misiekhardcore requested review from a team, abdul99ahad and philippfromme and removed request for a team and abdul99ahad November 14, 2024 15:09
@misiekhardcore misiekhardcore marked this pull request as ready for review November 14, 2024 15:09
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 14, 2024
@barmac
Copy link
Member

barmac commented Nov 14, 2024

bump: update zeebe-bpmn-moddle to v1.7.0

The current convention is to use deps: for production dependencies updates, and chore: for devdeps.

@barmac
Copy link
Member

barmac commented Nov 14, 2024

I just noticed that the task listeners are not removed when we switch the implementation to job worker. This requirement wasn't explicitly added in camunda/camunda-modeler#4590 so I added it, and the implementation should be done in the new feature from camunda/camunda-bpmn-js-behaviors#88

Screen.Recording.2024-11-14.at.16.57.45.mov

@misiekhardcore
Copy link
Contributor Author

misiekhardcore commented Nov 15, 2024

@barmac is there any way of testing this during development?
EDIT: I linked them together and it seems to be working so I can test my changes as I go

@barmac
Copy link
Member

barmac commented Nov 15, 2024

@barmac is there any way of testing this during development? EDIT: I linked them together and it seems to be working so I can test my changes as I go

Linking is the approach, and then you can npm start as with most of the projects.

@misiekhardcore misiekhardcore merged commit 94572dc into main Nov 18, 2024
10 checks passed
@misiekhardcore misiekhardcore deleted the user-task-listener branch November 18, 2024 13:26
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants