Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run task listener cleanup on properties change #90

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

misiekhardcore
Copy link
Contributor

@misiekhardcore misiekhardcore commented Nov 15, 2024

Currently task listeners are not removed when user task implementation property is changed to job worker.
This PR adds running the task listener cleanup on user task properties change

Related to camunda/camunda-modeler#4590

Context

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 15, 2024
@misiekhardcore misiekhardcore requested review from barmac, a team and philippfromme and removed request for a team November 15, 2024 10:12
Copy link
Contributor

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] Consider adding a test case for non-behavior, i.e. "should NOT remove task listeners when a form definition is added". Right now we only check when the properties should be removed, but that will pass as well if we always remove the properties.

@misiekhardcore misiekhardcore merged commit 110dc0b into main Nov 18, 2024
5 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 18, 2024
@misiekhardcore misiekhardcore deleted the user-task-listener-cleanup-fix branch November 18, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants