[test] Add test case for geographic intersection for polygons touching North Pole #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| boost::geometry::intersection(bigTileOn90,usa,out1); | ||
| boost::geometry::intersection(bigTile,usa,out2); | ||
| BOOST_CHECK(out1.size() == 1); | ||
| BOOST_CHECK(boost::geometry::area(out1) == boost::geometry::area(out2)); |
There was a problem hiding this comment.
Shouldn't we use a floating-point check with epsilon?
There was a problem hiding this comment.
That should be OK without epsilon because the two computed polygons are exactly the same and thus their areas.
|
|
||
| BOOST_AUTO_TEST_CASE(usaIntersectBigTile90) { | ||
| auto bigTileWKt = "POLYGON((-182.25 -2.25,-182.25 85,-90 85,4.5 85,4.5 -2.25,-90 -2.25,-182.25 -2.25))"; | ||
| auto bigTileWKtOn90 = "POLYGON((-182.25 -2.25,-182.25 90,-90 90,4.5 90,4.5 -2.25,-90 -2.25,-182.25 -2.25))"; |
There was a problem hiding this comment.
I think we never use this camelCase convention...
Also (minor), can be const
There was a problem hiding this comment.
Thanks you are right, I was just copy-pasting here from the original issue. Fixed now.
barendgehrels
approved these changes
Oct 2, 2024
vissarion
force-pushed
the
add_test_cases
branch
from
3fe91f5 to
5c78d67
Compare
vissarion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test case from issue #480