Fix CCW and isolated turns #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barendgehrels
approved these changes
Mar 26, 2024
|
|
||
| constexpr auto order2 = geometry::point_order<Geometry2>::value; | ||
| constexpr bool reverse2 = (order2 == boost::geometry::counterclockwise) | ||
| ? ! Reverse2 : Reverse2; |
There was a problem hiding this comment.
👍 great fix, thanks a lot
| ut_settings settings; | ||
| settings.set_test_validity(! is_ccw); | ||
| settings.set_test_validity(true); |
There was a problem hiding this comment.
This works - but you can also remove the settings and just call TEST_INTERSECTION (here and below)
vissarion
force-pushed
the
fix/invalid_setops
branch
from
006b009 to
c02a8f6
Compare
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #1231, #1244 (and a few more test cases). I want to target 1.85 if possible.