Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difference returns wrong result if hole touch the boundary of subtrahend #1244

Closed
evgeniyfeder opened this issue Feb 22, 2024 · 2 comments
Closed

Difference returns wrong result if hole touch the boundary of subtrahend #1244

evgeniyfeder opened this issue Feb 22, 2024 · 2 comments
Assignees
@barendgehrels
Labels
bug

Comments

@evgeniyfeder
Copy link

Hello
Actual result: Purple - orange = green.


Expected result: blue

I noticed that the problem was added in 1.77->1.78. Related PR could be: #887

https://godbolt.org/z/s7zKKbG61
@barendgehrels barendgehrels self-assigned this Mar 3, 2024
@barendgehrels
Copy link
Collaborator

Thanks for the report and the potential related PR, I can reproduce it. Clockwise is fine, but counter clockwise is wrong.

barendgehrels added a commit to barendgehrels/geometry that referenced this issue Mar 3, 2024
@barendgehrels
[test] add cases for issues boostorg#1229 boostorg#1231 boostorg#1244 …
0c44481 
…and some test refactoring
barendgehrels added a commit that referenced this issue Mar 13, 2024
@barendgehrels
[test] add cases for issues #1229 #1231 #1244 and some test refactoring
52fc1f6
@vissarion vissarion mentioned this issue Mar 26, 2024
Merged
@vissarion
Copy link
Member

vissarion commented Apr 1, 2024 •
edited
Loading

Fixed by #1263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barendgehrels barendgehrels

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@barendgehrels @vissarion @evgeniyfeder