-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint to get order from quote id #305
Draft
nicolenorman
wants to merge
1
commit into
main
Choose a base branch
from
get-order-by-quoteId
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<?php | ||
|
||
namespace Bold\Checkout\Api\Order; | ||
|
||
use Magento\Sales\Api\Data\OrderInterface; | ||
|
||
/** | ||
* Gets the order from the quote id. | ||
*/ | ||
interface GetOrderFromQuoteIdInterface | ||
{ | ||
/** | ||
* @param int $quoteId | ||
* @return \Magento\Sales\Api\Data\OrderInterface | ||
*/ | ||
public function getOrder(int $quoteId): OrderInterface; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
<?php | ||
declare(strict_types=1); | ||
|
||
namespace Bold\Checkout\Model\Order; | ||
|
||
use Bold\Checkout\Api\Order\GetOrderFromQuoteIdInterface; | ||
use Magento\Framework\Api\SearchCriteriaBuilder; | ||
use Magento\Framework\Exception\LocalizedException; | ||
use Magento\Sales\Api\Data\OrderInterface; | ||
use Magento\Sales\Api\OrderRepositoryInterface; | ||
|
||
class GetOrderFromQuoteId implements GetOrderFromQuoteIdInterface | ||
{ | ||
/** | ||
* @var OrderRepositoryInterface | ||
*/ | ||
private $orderRepository; | ||
|
||
/** | ||
* @var SearchCriteriaBuilder | ||
*/ | ||
private $searchCriteriaBuilder; | ||
|
||
public function __construct( | ||
OrderRepositoryInterface $orderRepository, | ||
SearchCriteriaBuilder $searchCriteriaBuilder | ||
) { | ||
$this->orderRepository = $orderRepository; | ||
$this->searchCriteriaBuilder = $searchCriteriaBuilder; | ||
} | ||
|
||
/** | ||
* @param int $quoteId | ||
* @return OrderInterface | ||
* @throws LocalizedException | ||
*/ | ||
public function getOrder(int $quoteId): OrderInterface | ||
{ | ||
$searchCriteria = $this->searchCriteriaBuilder | ||
->addFilter(OrderInterface::QUOTE_ID, $quoteId) | ||
->create(); | ||
|
||
$ordersList = $this->orderRepository->getList($searchCriteria); | ||
|
||
if ($ordersList->getTotalCount() === 0) { | ||
throw new LocalizedException(__('No order found with quote id="%1"', $quoteId)); | ||
} | ||
|
||
$orders = $ordersList->getItems(); | ||
return reset($orders); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to confirm with a Magento expert if quote id's are long lived. I thought I had heard something in the past that quote id's expire or can be cleared out by the merchant. If so, this may result in this endpoint being a new failure point for Bold.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calin is correct, to the best of my knowledge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the change in approach for the ticket this was related to it looks like this endpoint won't be needed. That on top of it sounding like this isn't a stable approach anyway I'll be closing this once the PR in the other project has been merged. Thank you both!