Add endpoint to get order from quote id #305
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolenorman
force-pushed
the
get-order-by-quoteId
branch
from
5ad9c75
to
df25618
Compare
TanyaP-sdet
approved these changes
Aug 8, 2024
CalinR
reviewed
Aug 8, 2024
| */ | ||
| public function getOrder(int $quoteId): OrderInterface | ||
| { | ||
| $searchCriteria = $this->searchCriteriaBuilder |
There was a problem hiding this comment.
We may want to confirm with a Magento expert if quote id's are long lived. I thought I had heard something in the past that quote id's expire or can be cleared out by the merchant. If so, this may result in this endpoint being a new failure point for Bold.
There was a problem hiding this comment.
Calin is correct, to the best of my knowledge.
There was a problem hiding this comment.
With the change in approach for the ticket this was related to it looks like this endpoint won't be needed. That on top of it sounding like this isn't a stable approach anyway I'll be closing this once the PR in the other project has been merged. Thank you both!
JosephLeedy
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new endpoint to allow getting an order from a quote_id