build: Rename `PACKAGE_` variables to `CLIENT_` #31042

hebasto · 2024-10-06T21:37:11Z

The use of PACKAGE_NAME for the project's variable name is problematic, as this name is commonly used in CMake's interface variables. If third-party CMake code handles with scopes improperly, our PACKAGE_NAME variable could end up with an unexpected value.

This PR avoids such conflicts by renaming all PACKAGE_* variables to CLIENT_*.

The code in the master branch works correctly only incidentally. It is definitely broken in #30997.

DrahtBot · 2024-10-06T21:37:14Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	TheCharlatan
Stale ACK	pablomartin4btc

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#bitcoin-core/gui/762 (Update about logo icon (colour) to denote the chain type of the QT instance in About/ Help Message Window/ Dialog by pablomartin4btc)
#31157 (Cleanups to port mapping module post UPnP drop by darosior)
#31149 (tinyformat: enforce compile-time checks for format string literals by stickies-v)
#31130 (Drop miniupnp dependency by darosior)
#31072 (refactor: Clean up messy strformat and bilingual_str usages by ryanofsky)
#31061 (refactor: Check translatable format strings at compile-time by maflcko)
#30988 (Split CConnman by vasild)
#30909 (wallet, assumeutxo: Don't Assume m_chain_tx_count, Improve wallet RPC errors by fjahr)
#29686 (Update manpage descriptions by willcl-ark)
#29641 (scripted-diff: Use LogInfo over LogPrintf [WIP, NOMERGE, DRAFT] by maflcko)
#28710 (Remove the legacy wallet and BDB dependency by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

CMakeLists.txt

pablomartin4btc

ACK c87a9d2

hebasto · 2024-10-08T13:23:57Z

Friendly ping @ryanofsky @theuni :)

DrahtBot · 2024-10-08T15:40:07Z

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit `62e4516` (master)	commit `5ed6cea` (master and this pull)
SHA256SUMS.part	`f2d49fb72517ef0c...`	`5005efffcf410479...`
*-aarch64-linux-gnu-debug.tar.gz	`d37cbe26a25f7540...`	`3f36a94db3e92d66...`
*-aarch64-linux-gnu.tar.gz	`42b4d4db0c531caf...`	`63ff5a599fe8b19a...`
*-arm-linux-gnueabihf-debug.tar.gz	`63eddcf3cfdb6c32...`	`c0cf87d19e7eeb27...`
*-arm-linux-gnueabihf.tar.gz	`fd2eb3904357b5f4...`	`39bf6e96d0321ba8...`
*-arm64-apple-darwin-unsigned.tar.gz	`71a08c8f938313cf...`	`66071da60789cfd8...`
*-arm64-apple-darwin-unsigned.zip	`ed11994d8f055418...`	`6fd1ec5eb314df65...`
*-arm64-apple-darwin.tar.gz	`0c11a002f4f3030c...`	`5e085108ec8ca844...`
*-powerpc64-linux-gnu-debug.tar.gz	`a76483c3abcddcc1...`	`90df5b5ffc6f8d2f...`
*-powerpc64-linux-gnu.tar.gz	`335ec17b370a19d5...`	`2c19cf3041bb430b...`
*-riscv64-linux-gnu-debug.tar.gz	`8494e354e088382e...`	`2465908aa76e7efe...`
*-riscv64-linux-gnu.tar.gz	`457df2421685bdda...`	`98b4e7a065d219fc...`
*-x86_64-apple-darwin-unsigned.tar.gz	`3cedc5861a78c8a5...`	`944bd6e444d3074c...`
*-x86_64-apple-darwin-unsigned.zip	`19b332dccbc792b4...`	`1169a427b1a26c57...`
*-x86_64-apple-darwin.tar.gz	`54c6788eb266f818...`	`7d62f24640f698f5...`
*-x86_64-linux-gnu-debug.tar.gz	`a761c3712ed00392...`	`84e9676d3421743a...`
*-x86_64-linux-gnu.tar.gz	`fceda20d8f50b5ab...`	`0c91cd3c3f4d58fa...`
*.tar.gz	`38978a4be1a7c7eb...`	`a6d8a1494135eebd...`
guix_build.log	`022bedb7b63b12f2...`	`098d5b76f7a1c904...`
guix_build.log.diff		`e451373908777661...`

DrahtBot · 2024-10-11T10:35:06Z

🚧 At least one of the CI tasks failed.
_{Debug: https://github.com/bitcoin/bitcoin/runs/31403424642}

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the
affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

hebasto · 2024-10-24T12:52:19Z

It is definitely broken in #30997.

Shouldn't #30997 be based on this PR then (or at least mention in the PR description it's expected to be broken)?

Done.

DrahtBot · 2024-10-24T14:00:06Z

🚧 At least one of the CI tasks failed.
_{Debug: https://github.com/bitcoin/bitcoin/runs/32008030836}

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the
affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

cmake/module/GenerateSetupNsi.cmake

pablomartin4btc

re-ACK 36a3de0

Since my previous review: extended renaming to the rest of sources where PACKAGE_ namespace existed.

DrahtBot · 2024-10-25T05:15:58Z

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit `74fb193` (master)	commit `18c7892` (master and this pull)
SHA256SUMS.part	`ad80f9275f7592f5...`	`105f7e99fe2ea776...`
*-aarch64-linux-gnu-debug.tar.gz	`e3f077c9e2efe42c...`	`d941af501de3c4bc...`
*-aarch64-linux-gnu.tar.gz	`84c5837e967a705e...`	`c789aa4991d87907...`
*-arm-linux-gnueabihf-debug.tar.gz	`198436220bbb764e...`	`3141966da9a55a69...`
*-arm-linux-gnueabihf.tar.gz	`8ab9ee456035f028...`	`e9d2ada88260f063...`
*-arm64-apple-darwin-unsigned.tar.gz	`5f3493c8841e7000...`	`cd6c42f626601e75...`
*-arm64-apple-darwin-unsigned.zip	`53586205b08dae04...`	`f7e514b0c15f7f63...`
*-arm64-apple-darwin.tar.gz	`9bc61a1a9c494690...`	`18d89fae96719424...`
*-powerpc64-linux-gnu-debug.tar.gz	`d736c35074e1ab00...`	`d432fb4e0d5ecdbb...`
*-powerpc64-linux-gnu.tar.gz	`dc3411d9d8e023d0...`	`d2cdc438582b7920...`
*-riscv64-linux-gnu-debug.tar.gz	`14f550c7e6be73cb...`	`d458b01297d7d6f7...`
*-riscv64-linux-gnu.tar.gz	`a5ce20b057de5651...`	`8cca56c53745b49c...`
*-x86_64-apple-darwin-unsigned.tar.gz	`0a5aeae59a745fdd...`	`bfff017a6e65f5d3...`
*-x86_64-apple-darwin-unsigned.zip	`c17d6c147152032f...`	`d34ff50cdbe2148b...`
*-x86_64-apple-darwin.tar.gz	`eb310f282a01918f...`	`4eb8c4509b9386d2...`
*-x86_64-linux-gnu-debug.tar.gz	`788598dd19a44259...`	`da42106f8faa2beb...`
*-x86_64-linux-gnu.tar.gz	`6b13f937a5601c35...`	`3f4c088c211451f5...`
*.tar.gz	`d344eb18d56160d8...`	`a12f34aad2744538...`
guix_build.log	`baf52e47221c27f4...`	`93b59c7bc5b0979d...`
guix_build.log.diff		`9e667259d151f4f3...`

TheCharlatan

ACK 36a3de0

The last two commits could be squashed together though? I don't think that would complicate the scripted diff.

hebasto · 2024-10-26T12:28:59Z

The last two commits could be squashed together though? I don't think that would complicate the scripted diff.

Thanks! Squashed.

TheCharlatan

Re-ACK 2076a08

This change allows to the use of the `CLIENT_` namespace without potential name clashes. -BEGIN VERIFY SCRIPT- sed -i "s/\<CLIENT_NAME\>/UA_NAME/g" $( git grep -l "CLIENT_NAME" ./src) -END VERIFY SCRIPT-

The use of `PACKAGE_NAME` for the project's variable name is problematic, as this name is commonly used in CMake's interface variables. If third-party CMake code handles with scopes improperly, our `PACKAGE_NAME` variable could end up with an unexpected value. This change avoids such conflicts by renaming all `PACKAGE_*` variables to `CLIENT_*`.

This change ensures consistent use of the `CLIENT_` namespace everywhere in the repository. -BEGIN VERIFY SCRIPT- ren() { sed -i "s/\<$1\>/$2/g" $( git grep -l "$1" ./cmake ./src :$exclude$./src/secp256k1 ./test ) ; } ren PACKAGE_NAME CLIENT_NAME ren PACKAGE_VERSION CLIENT_VERSION_STRING ren PACKAGE_URL CLIENT_URL ren PACKAGE_BUGREPORT CLIENT_BUGREPORT -END VERIFY SCRIPT-

hebasto · 2024-10-28T12:37:31Z

Rebased due to the conflict with the merged #31130.

TheCharlatan

Re-ACK 7071330

fanquake · 2024-10-28T15:22:46Z

Guix Build:

2df1f3823c8f689140e3a400f0fdc49d4fe0d2bc4d29402d9765bf9821147b28  guix-build-70713303b639/output/aarch64-linux-gnu/SHA256SUMS.part
33a4689e3200b0fbd56d8098b33cf9388baebe641d27dd6dc09813f56ea2abb1  guix-build-70713303b639/output/aarch64-linux-gnu/bitcoin-70713303b639-aarch64-linux-gnu-debug.tar.gz
35f43ddc81853d054544bbe70d7d8461867c026a7b4d3c9ae90ee248bf28c9de  guix-build-70713303b639/output/aarch64-linux-gnu/bitcoin-70713303b639-aarch64-linux-gnu.tar.gz
b87c9dd6990934021ef5a421e46d0159b822b1ddd4457a7bcbad3ab0763eb279  guix-build-70713303b639/output/arm-linux-gnueabihf/SHA256SUMS.part
da4a4a1dcee0d6b0f210b25b8e0320dda1f2249efb90a7677cafcf2f00c1eb56  guix-build-70713303b639/output/arm-linux-gnueabihf/bitcoin-70713303b639-arm-linux-gnueabihf-debug.tar.gz
925b1d6cf6fb2c59a34c74a05053278d88ed7ee84ddeb960f39599835fd31a8e  guix-build-70713303b639/output/arm-linux-gnueabihf/bitcoin-70713303b639-arm-linux-gnueabihf.tar.gz
1a36013e0f1585b5c8ffe4e39fa24638481a2c38d8dafc9aaaece11698236b92  guix-build-70713303b639/output/arm64-apple-darwin/SHA256SUMS.part
9bfcbd2ddc619ccca320424a0520e79f8489c28207093e855bba48322a48f24a  guix-build-70713303b639/output/arm64-apple-darwin/bitcoin-70713303b639-arm64-apple-darwin-unsigned.tar.gz
59c841f7b385bd9645cef3e4b1a5f93b2ef577a276e06418f919180ee23d7e4d  guix-build-70713303b639/output/arm64-apple-darwin/bitcoin-70713303b639-arm64-apple-darwin-unsigned.zip
57019be46ef95ea27ca5a4fb3d29c78782988fbe15ee893aa912b43b3da7dfa0  guix-build-70713303b639/output/arm64-apple-darwin/bitcoin-70713303b639-arm64-apple-darwin.tar.gz
ab6762e153f42dfb37d21d205c14a9ff3fd381b74141a45b9ea38ee129e856e5  guix-build-70713303b639/output/dist-archive/bitcoin-70713303b639.tar.gz
fb9b9719b2769406a6d7d4ad05d737b954c51f374385cb44a336272c3c291736  guix-build-70713303b639/output/powerpc64-linux-gnu/SHA256SUMS.part
d4f2cdf931b7bba6c4d9291ea930659c04fd6a7a3a9682c5268ee96145861c97  guix-build-70713303b639/output/powerpc64-linux-gnu/bitcoin-70713303b639-powerpc64-linux-gnu-debug.tar.gz
f9db6ed69d00b9dfaa72fe7a0658e19b3c841ea0b4ada59a5cd4659dd330d392  guix-build-70713303b639/output/powerpc64-linux-gnu/bitcoin-70713303b639-powerpc64-linux-gnu.tar.gz
8167118fcef084f28831e6bece33eb2061404fa0f7e96d629a95d3f329ba5310  guix-build-70713303b639/output/riscv64-linux-gnu/SHA256SUMS.part
819cd35f0c32a68a545347adb0f6bc6e53c0d243a4bacf37cebf99b400648b35  guix-build-70713303b639/output/riscv64-linux-gnu/bitcoin-70713303b639-riscv64-linux-gnu-debug.tar.gz
521107405bccfd2032356dd06227391d696ebaf1edf87a24330b4d78bb55af49  guix-build-70713303b639/output/riscv64-linux-gnu/bitcoin-70713303b639-riscv64-linux-gnu.tar.gz
1eb6cbf97f5c9a0e66c204b141f6f4780374242b05ac2f55e47fdb571abbafda  guix-build-70713303b639/output/x86_64-apple-darwin/SHA256SUMS.part
509038ecfac467f801f06078868bf52de2918928faea4d2aae9a5784732f976c  guix-build-70713303b639/output/x86_64-apple-darwin/bitcoin-70713303b639-x86_64-apple-darwin-unsigned.tar.gz
213a190c1cfed5f40089b078cef860ffc1ba3a0bedc7e489e89658db40718bef  guix-build-70713303b639/output/x86_64-apple-darwin/bitcoin-70713303b639-x86_64-apple-darwin-unsigned.zip
691f5cd5e4f9659ef15161cc4f30a797c6abd803f60e4eeba36b9d391b23981d  guix-build-70713303b639/output/x86_64-apple-darwin/bitcoin-70713303b639-x86_64-apple-darwin.tar.gz
3c2b462b300659fcf46537c67ceac879f3d5e850c988bb172bb6514dac7701c0  guix-build-70713303b639/output/x86_64-linux-gnu/SHA256SUMS.part
2d9cc4effcc041f87fb6054e56a206694ccf133c32ae62dc4bb6f2107a589beb  guix-build-70713303b639/output/x86_64-linux-gnu/bitcoin-70713303b639-x86_64-linux-gnu-debug.tar.gz
b3d11e2a55ae7cf03f601527816052214596e2270190f89a151eac4e8796c465  guix-build-70713303b639/output/x86_64-linux-gnu/bitcoin-70713303b639-x86_64-linux-gnu.tar.gz
225ec52f051ec7410b29f30b9c36898f330fb5d94267f242b39a18711b4bbe37  guix-build-70713303b639/output/x86_64-w64-mingw32/SHA256SUMS.part
8f022cecbedf22324778983b9d8b7351d24a1d51297e7124f06bf82cc5490bbd  guix-build-70713303b639/output/x86_64-w64-mingw32/bitcoin-70713303b639-win64-debug.zip
0243301dcff8850146901e77b0e58659594fb7108193004c11fa46d5ded439e9  guix-build-70713303b639/output/x86_64-w64-mingw32/bitcoin-70713303b639-win64-setup-unsigned.exe
97938f0053cf1f361817d8bb750461a809f05983ea7d030d61222c53053e91e7  guix-build-70713303b639/output/x86_64-w64-mingw32/bitcoin-70713303b639-win64-unsigned.tar.gz
8e205188361743d291fe4317741a05b7d205c6a7df22c07338a1aaad49159507  guix-build-70713303b639/output/x86_64-w64-mingw32/bitcoin-70713303b639-win64.zip

…158303fe2 48158303fe2 kernel: Add pure kernel bitcoin-chainstate bf80d2f5009 kernel: Add block index utility functions to C header a6ab5345e3b kernel: Add function to read block undo data from disk to C header 845b824d6c7 kernel: Add functions to read block from disk to C header 9324c8c4f67 kernel: Add function for copying block data to C header 368fc93fd80 kernel: Add functions for the block validation state to C header eb6e25ac007 kernel: Add validation interface to C header cdce4484005 kernel: Add interrupt function to C header 7e47ec78768 kernel: Add import blocks function to C header 2b803d50747 kernel: Add chainstate load options for in-memory dbs in C header ea92eb13c4a kernel: Add options for reindexing in C header 8254f2035a7 kernel: Add block validation to C header ad7b880346e Kernel: Add chainstate loading to kernel C header 583820c4487 kernel: Add chainstate manager object to C header ec137a086a0 kernel: Add notifications context option to C header 62a89689266 kerenl: Add chain params context option to C header bb482dcbd30 kernel: Add kernel library context object d114ccfdf8a kernel: Add logging to kernel library C header 44c65c46c43 kernel: Introduce initial kernel C header API 69c03134440 Merge bitcoin/bitcoin#31269: validation: Remove RECENT_CONSENSUS_CHANGE validation result 42282592943 Merge bitcoin/bitcoin#31000: bench: add support for custom data directory 36f5effa178 Merge bitcoin/bitcoin#31235: addrman: cap the `max_pct` to not exceed the maximum number of addresses 98ad249b69f Merge bitcoin/bitcoin#31277: doc: mention `descriptorprocesspsbt` in psbt.md b0222bbb494 Merge bitcoin/bitcoin#30239: Ephemeral Dust 1dda1892b6b Merge bitcoin/bitcoin#31037: test: enhance p2p_orphan_handling 5c2e291060c bench: Add basic CheckEphemeralSpends benchmark 3f6559fa581 Add release note for ephemeral dust 71a6ab4b33d test: unit test for CheckEphemeralSpends 21d28b2f362 fuzz: add ephemeral_package_eval harness 127719f516a test: Add CheckMempoolEphemeralInvariants e2e30e89ba4 functional test: Add ephemeral dust tests 4e68f901390 rpc: disallow in-mempool prioritisation of dusty tx e1d3e81ab4d policy: Allow dust in transactions, spent in-mempool 04b2714fbbc functional test: Add new -dustrelayfee=0 test case ebb6cd82baf doc: mention `descriptorprocesspsbt` in psbt.md 2b33322169b Merge bitcoin/bitcoin#31249: test: Add combinerawtransaction test to rpc_createmultisig 3fb6229dcfd Merge bitcoin/bitcoin#31271: doc: correct typos fa66e0887ca bench: add support for custom data directory ad9c2cceda9 test, bench: specialize working directory name 9c5775c331e addrman: cap the `max_pct` to not exceed the maximum number of addresses 8d340be9247 Merge bitcoin/bitcoin#31181: cmake: Revamp `FindLibevent` module 9a8e5adb161 Merge bitcoin/bitcoin#31267: refactor: Drop deprecated space in operator""_mst 726cbee9553 doc: correct typos 9fdfb73ca84 doc: fix typos af6088701a2 Merge bitcoin/bitcoin#31237: doc: Add missing 'blank=true' option in offline-signing-tutorial.md 7a526653022 Merge bitcoin/bitcoin#31239: test: clarify log messages when handling SOCKS5 proxy connections 900b17239fb Merge bitcoin/bitcoin#31259: doc: Fix missing comma in JSON example in REST-interface.md faf21625652 refactor: Drop deprecated space in operator""_mst c889890e4a3 Merge bitcoin/bitcoin#31264: doc: Fixup bitcoin-wallet manpage chain selection args 0f6d20e43f2 Merge bitcoin/bitcoin#31163: scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp} 5acd5e7f874 Merge bitcoin/bitcoin#31257: ci: make ctest stop on failure 19f277711eb Merge bitcoin/bitcoin#26593: tracing: Only prepare tracepoint arguments when actually tracing e80e4c6ff91 validation: Remove RECENT_CONSENSUS_CHANGE validation result fa729ab4a27 doc: Fixup bitcoin-wallet manpage chain selection args 5e3b444022c doc: Fix missing comma in JSON example in REST-interface.md 0903ce8dbc2 Merge bitcoin/bitcoin#30592: Remove mempoolfullrbf f842d0801e1 Merge bitcoin/bitcoin#29686: Update manpage descriptions 36a22e56833 ci: make ctest stop on failure 83fab3212c9 test: Add combinerawtransaction test to rpc_createmultisig 018e5fcc462 Merge bitcoin/bitcoin#31190: TxDownloadManager followups 3a5f6027e16 Merge bitcoin/bitcoin#31171: depends: Specify CMake generator explicitly 99d9a093cf6 test: clarify log messages when handling SOCKS5 proxy connections c9e67e214f0 Merge bitcoin/bitcoin#31238: fuzz: Limit wallet_notifications iterations 564238aabf1 Merge bitcoin/bitcoin#31164: net: Use actual memory size in receive buffer accounting fa461d7a43a fuzz: Limit wallet_notifications iterations ec375de39ff doc: Add missing 'blank=true' option in offline-signing-tutorial.md 5a96767e3f5 depends, libevent: Do not install *.pc files and remove patches for them ffda355b5a2 cmake, refactor: Move `HAVE_EVHTTP_...` to `libevent` interface b619bdc3303 cmake: Revamp `FindLibevent` module 2c90f8e08c4 Merge bitcoin/bitcoin#31232: ci: `add second_deadlock_stack=1` to TSAN options 5dc94d13d41 fuzz fix: assert MAX_PEER_TX_ANNOUNCEMENTS is not exceeded 45e2f8f87d8 Merge bitcoin/bitcoin#31173: cmake: Add `FindQRencode` module and enable `libqrencode` package for MSVC 80cb630bd94 Merge bitcoin/bitcoin#31216: Update secp256k1 subtree to v0.6.0 5161c2618cd ci: add second_deadlock_stack=1 to TSAN options 85224f92d52 Merge bitcoin/bitcoin#30811: build: Unify `-logsourcelocations` format 9719d373dc2 Merge bitcoin/bitcoin#30634: ci: Use clang-19 from apt.llvm.org 97235c446e9 build: Disable secp256k1 musig module 9e5089dbb02 build, msvc: Enable `libqrencode` vcpkg package 30089b0cb61 cmake: Add `FindQRencode` module 65b19419366 Merge bitcoin/bitcoin#31186: msvc: Update vcpkg manifest d3388720837 Merge bitcoin/bitcoin#31206: doc: Use relative hyperlinks in release-process.md ffc05fca6f7 Merge bitcoin/bitcoin#31220: doc: Fix word order in developer-notes.md 9f2c8287a24 Merge bitcoin/bitcoin#31192: depends, doc: List packages required to build `qt` package separately 03cff2c1421 Merge bitcoin/bitcoin#31191: build: Make G_FUZZING constexpr, require -DBUILD_FOR_FUZZING=ON to fuzz 44939e5de1b doc: Fix word order in developer-notes.md b934954ad10 Merge bitcoin/bitcoin#30670: doc: Extend developer-notes with file-name-only debugging fix 05aebe3790f Merge bitcoin/bitcoin#30930: netinfo: add peer services column and outbound-only option 0ba680d41b4 Update secp256k1 subtree to v0.6.0 2d46a89386d Squashed 'src/secp256k1/' changes from 2f2ccc46954..0cdc758a563 d22a234ed27 net: Use actual memory size in receive buffer accounting 047b5e2af1f streams: add DataStream::GetMemoryUsage c3a6722f34a net: Use DynamicUsage(m_type) in CSerializedNetMsg::GetMemoryUsage c6594c0b142 memusage: Add DynamicUsage for std::string 7596282a556 memusage: Allow counting usage of vectors with different allocators 6463117a292 Merge bitcoin/bitcoin#31208: doc: archive release notes for v27.2 788c1324f3d build: Unify `-logsourcelocations` format 4747f030956 depends, doc: List packages required to build `qt` package separately 1a05c86ae47 doc: archive release notes for v27.2 9f71cff6ab3 doc: Use relative hyperlinks in release-process.md f1bcf3edc50 Merge bitcoin/bitcoin#31139: test: added test to assert TX decode rpc error on submitpackage rpc 975b115e1a2 Merge bitcoin/bitcoin#31198: init: warn, don't error, when '-upnp' is set 4a0251c05dd Merge bitcoin/bitcoin#31187: ci: Do not error on unused-member-function in test each commit e001dc3dc6e Merge bitcoin/bitcoin#31203: fuzz: fix `implicit-integer-sign-change` in wallet_create_transaction 5a26cf7773e fuzz: fix `implicit-integer-sign-change` in wallet_create_transaction a1b3ccae4be init: warn, don't error, when '-upnp' is set c189eec848e doc: release note for mempoolrullrbf removal d47297c6aab rpc: Mark fullrbf and bip125-replaceable as deprecated 04a5dcee8ab docs: remove requirement to signal bip125 fafbf8acf41 Make G_FUZZING constexpr, require -DBUILD_FOR_FUZZING=ON to execute a fuzz target fae3cf0ffa6 ci: Temporarily disable macOS/Windows fuzz step f6577b71741 build, msvc: Update vcpkg manifest baseline 16e16013bfa build, msvc: Document `libevent` version pinning ec47cd2b508 build, msvc: Drop no longer needed `liblzma` version pinning 9a0734df5f1 build, msvc: Reorder keys in `vcpkg.json` 8351562bec6 [fuzz] allow negative time jumps in txdownloadman_impl 917ab810d93 [doc] comment fixups from n30110 f07a533dfcb Merge bitcoin/bitcoin#24214: Fix unsigned integer overflows in interpreter 62516105536 Merge bitcoin/bitcoin#31015: build: have "make test" depend on "make all" 4a31f8ccc9d Merge bitcoin/bitcoin#31156: test: Don't enforce BIP94 on regtest unless specified by arg 02be3dced71 Merge bitcoin/bitcoin#31166: key: clear out secret data in `DecodeExtKey` 54d07dd37d5 ci: Do not error on unused-member-function in test each commit 47f50c7af55 doc: add bitcoin-qt man description 40b82e3ab0a doc: add bitcoin-util man description a7bf80f3a2d doc: add bitcoin-tx man description 3f9a5168323 doc: add bitcoin-wallet man description d8c0bb23ef8 doc: add bitcoin-cli man description 09abccfa772 doc: add bitcoind man description 97b790e844a Merge bitcoin/bitcoin#29420: test: extend the SOCKS5 Python proxy to actually connect to a destination 6b73eb9a1a2 Merge bitcoin/bitcoin#31064: init: Correct coins db cache size setting 27d12cf17f2 Merge bitcoin/bitcoin#31043: rpc: getorphantxs follow-up 7b66815b16b Merge bitcoin/bitcoin#30110: refactor: TxDownloadManager + fuzzing dc97e7f6dba Merge bitcoin/bitcoin#30903: cmake: Add `FindZeroMQ` module 1b0b9b4c787 Extend possible debugging fixes with file-name-only da10e0bab4a Merge bitcoin/bitcoin#30942: test: Remove dead code from interface_zmq test 111a23d9b36 Remove -mempoolfullrbf option e96ffa98b04 Merge bitcoin/bitcoin#31142: test: fix intermittent failure in p2p_seednode.py, don't connect to random IPs 54c4b09f083 Merge bitcoin/bitcoin#31042: build: Rename `PACKAGE_*` variables to `CLIENT_*` e60cecc8115 doc: add release note for 31156 fc7dfb3df5b test: Don't enforce BIP94 on regtest unless specified by arg fabe90c8242 ci: Use clang-19 from apt.llvm.org 0de3e96e333 tracing: use bitcoind pid in bcc tracing examples 411c6cfc6c2 tracing: only prepare tracepoint args if attached d524c1ec066 tracing: dedup TRACE macros & rename to TRACEPOINT 70713303b63 scripted-diff: Rename `PACKAGE_*` variables to `CLIENT_*` 332655cb52c build: Rename `PACKAGE_*` variables to `CLIENT_*` e6e29e3c94c scripted-diff: Clarify "user agent" variable name e2ba8236715 depends: Specify CMake generator explicitly 1c7ca6e64de Merge bitcoin/bitcoin#31093: Introduce `g_fuzzing` global for fuzzing checks 6e21dedbf2b Merge bitcoin/bitcoin#31130: Drop miniupnp dependency d7fd766feb2 test: added test to assert TX decode rpc error on submitpackage rpc 559a8dd9c0a key: clear out secret data in `DecodeExtKey` 4120c7543ee scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp} 2a52718d734 Merge bitcoin/bitcoin#31152: functional test: Additional package evaluation coverage 9de9c858d5a test: enhance p2p_orphan_handling 33af14b62e4 test: reduce assert_debug_log reliance 0ea84bc362f test: explicitly check boolean verbosity is disallowed 7a2e6b68cd9 doc: add rpc guidance for boolean verbosity avoidance 698f302df8b rpc: disallow boolean verbosity in getorphantxs 63f5e6ec795 test: add entry and expiration time checks 808a708107e rpc: add entry time to getorphantxs 56bf3027144 refactor: rename rpc_getorphantxs to rpc_orphans 7824f6b0770 test: check that getorphantxs is hidden ac68fcca701 rpc: disallow undefined verbosity in getorphantxs 25dacae9c7f Merge bitcoin/bitcoin#31040: test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped 40e5f26a3ff mapport: remove dead code in DispatchMapPort 38fdf7c1fb1 mapport: drop outdated comments 915640e191b depends: zeromq: don't install .pc files and remove patches for them 6b8a74463b5 cmake: Add `FindZeroMQ` module 9a7206a34e3 Merge bitcoin/bitcoin#29536: fuzz: fuzz connman with non-empty addrman + ASMap d4abaf8c9d9 Merge bitcoin/bitcoin#29608: optimization: Preallocate addresses in GetAddr based on nNodes b7b24352906 doc: add release note for #31130 1b6dec98da3 depends: drop miniupnpc 953533d0214 doc: remove mentions of UPnP 94ad614482f ci: remove UPnP options f32c34d0c3d functional test: Additional package evaluation coverage 87532fe5585 netinfo: allow setting an outbound-only peer list 9f243cd7fa6 Introduce `g_fuzzing` global for fuzzing checks b95adf057a4 Merge bitcoin/bitcoin#31150: util: Treat Assume as Assert when evaluating at compile-time 8f24e492e20 Merge bitcoin/bitcoin#29991: depends: sqlite 3.46.1 2ef5004f78c Merge bitcoin/bitcoin#31146: ci: Temporary workaround for old CCACHE_DIR cirrus env 8c12fe828de Merge bitcoin/bitcoin#29936: fuzz: wallet: add target for `CreateTransaction` 5c299ecafe6 test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped 0f4bc635854 [fuzz] txdownloadman and txdownload_impl 699643f23a1 [unit test] MempoolRejectedTx fa584cbe727 [p2p] add TxDownloadOptions bool to make TxRequestTracker deterministic f803c8ce8dd [p2p] filter 1p1c for child txid in recent rejects 5269d57e6d7 [p2p] don't process orphan if in recent rejects 2266eba43a9 [p2p] don't find 1p1cs for reconsiderable txns that are AlreadyHaveTx fa7027d0fc1 [refactor] add CheckIsEmpty and GetOrphanTransactions, remove access to TxDownloadMan internals 969b07237b9 [refactor] wrap {Have,Get}TxToReconsider in txdownload f150fb94e7d [refactor] make AlreadyHaveTx and Find1P1CPackage private to TxDownloadImpl 1e08195135b [refactor] move new tx logic to txdownload 257568eab5b [refactor] move invalid package processing to TxDownload c4ce0c1218d [refactor] move invalid tx processing to TxDownload c6b21749ca0 [refactor] move valid tx processing to TxDownload a8cf3b6e845 [refactor] move Find1P1CPackage to txdownload f497414ce76 [refactor] put peerman tasks at the end of ProcessInvalidTx 6797bc42a76 [p2p] restrict RecursiveDynamicUsage of orphans added to vExtraTxnForCompact 798cc8f5aac [refactor] move Find1P1CPackage into ProcessInvalidTx 416fbc952b2 [refactor] move new orphan handling to ProcessInvalidTx c8e67b9169b [refactor] move ProcessInvalidTx and ProcessValidTx definitions down 3a41926d1b5 [refactor] move notfound processing to txdownload 042a97ce7fc [refactor] move tx inv/getdata handling to txdownload 58e09f244b4 [p2p] don't log tx invs when in IBD 288865338f5 [refactor] rename maybe_add_extra_compact_tx to first_time_failure f48d36cd97e [refactor] move peer (dis)connection logic to TxDownload f61d9e4b4b8 [refactor] move AlreadyHaveTx to TxDownload 84e4ef843db [txdownload] add read-only reference to mempool af918349de5 [refactor] move ValidationInterface functions to TxDownloadManager f6c860efb12 [doc] fix typo in m_lazy_recent_confirmed_transactions doc 5f9004e1550 [refactor] add TxDownloadManager wrapping TxOrphanage, TxRequestTracker, and bloom filters 947f2925d55 Merge bitcoin/bitcoin#31124: util: Remove RandAddSeedPerfmon 7640cfdd624 Merge bitcoin/bitcoin#31118: doc: replace `-?` with `-h` and `-help` 74fb19317ae Merge bitcoin/bitcoin#30849: refactor: migrate `bool GetCoin` to return `optional<Coin>` c16e909b3e2 Merge bitcoin/bitcoin#28574: wallet: optimize migration process, batch db transactions a9598e5eaab build: drop miniupnpc dependency a5fcfb7385c interfaces: remove now unused 'use_upnp' arg from 'mapPort' 038bbe7b200 daemon: remove UPnP support 844770b05eb qt: remove UPnP settings dd92911732d Merge bitcoin/bitcoin#31148: ci: display logs of failed unit tests automatically fa69a5f4b76 util: Treat Assume as Assert when evaluating at compile-time 0c79c343a9f Merge bitcoin/bitcoin#31147: cmake, qt, test: Remove problematic code 8523d8c0fc8 ci: display logs of failed tests automatically 2f40e453ccd Merge bitcoin/bitcoin#29450: build: replace custom `MAC_OSX` macro with existing `__APPLE__` cb7c5ca824e Add gdb and lldb links to debugging troubleshooting 6c6b2442eda build: Replace MAC_OSX macro with existing __APPLE__ fb46d57d4e7 cmake, qt, test: Remove problematic code fa9747a8961 ci: Temporary workaround for old CCACHE_DIR cirrus env 6c9fe7b73ea test: Prevent connection attempts to random IPs in p2p_seednodes.py bb97b1ffa9f test: fix intermittent timeout in p2p_seednodes.py 57529ac4dbb test: set P2PConnection.p2p_connected_to_node in peer_connect_helper() 22cd0e888c7 test: support WTX INVs from P2PDataStore and fix a comment ebe42c00aa4 test: extend the SOCKS5 Python proxy to actually connect to a destination 9bb92c0e7ff util: Remove RandAddSeedPerfmon c98fc36d094 wallet: migration, consolidate external wallets db writes 7c9076a2d2e wallet: migration, consolidate main wallet db writes 9ef20e86d7f wallet: provide WalletBatch to 'SetupDescriptorScriptPubKeyMans' 34bf0795fc0 wallet: refactor ApplyMigrationData to return util::Result<void> aacaaaa0d3a wallet: provide WalletBatch to 'RemoveTxs' 57249ff6697 wallet: introduce active db txn listeners 91e065ec175 wallet: remove post-migration signals connection 055c0532fc8 wallet: provide WalletBatch to 'DeleteRecords' 122d103ca22 wallet: introduce 'SetWalletFlagWithDB' 6052c7891dc wallet: decouple default descriptors creation from external signer setup f2541d09e13 wallet: batch MigrateToDescriptor() db transactions 66c9936455f bench: add coverage for wallet migration process 33a28e252a7 Change default help arg to `-help` and mention `-h` and `-?` as alternatives f0130ab1a1e doc: replace `-?` with `-h` for bench_bitcoin help 681ebcceca7 netinfo: rename and hoist max level constant to use in top-level help e7d307ce8cf netinfo: clarify relaytxes and addr_relay_enabled help docs eef2a9d4062 netinfo: add peer services column 3a4a788ee0d init: Correct coins db cache size setting 2957ca96119 build: have "make test" depend on "make all" bbbbaa0d9ac Fix unsigned integer overflows in interpreter c4dc81f9c69 test: Remove dead code from interface_zmq c495731a316 fuzz: wallet: add target for `CreateTransaction` 3db68e29ec6 wallet: move `ImportDescriptors`/`FuzzedWallet` to util 552cae243a1 fuzz: cover `ASMapHealthCheck` in connman target 33b0f3ae966 fuzz: use `ConsumeNetGroupManager` in connman target 18c8a0945bd fuzz: move `ConsumeNetGroupManager` to util fe624631aeb fuzz: fuzz `connman` with a non-empty addrman 0a12cff2a8e fuzz: move `AddrManDeterministic` to util 4feaa287284 refactor: Rely on returned value of GetCoin instead of parameter 46dfbf169b4 refactor: Return optional of Coin in GetCoin e31bfb26c21 refactor: Remove unrealistic simulation state ba621ffb9cb test: improve debug log message from P2PConnection::connection_made() def6dd0c597 depends: sqlite 3.46.1 66082ca3488 Preallocate addresses in GetAddr based on nNodes REVERT: 1047757ea3b kernel: Add pure kernel bitcoin-chainstate REVERT: c568fdf75fd kernel: Add block index utility functions to C header REVERT: 0f1da1dcba5 kernel: Add function to read block undo data from disk to C header REVERT: 45af559c9f6 kernel: Add functions to read block from disk to C header REVERT: 2a7f8a8240c kernel: Add function for copying block data to C header REVERT: b19f5336c03 kernel: Add functions for the block validation state to C header REVERT: 9c0ffa913f4 kernel: Add validation interface to C header REVERT: a93318c6152 kernel: Add interrupt function to C header REVERT: 51053f33720 kernel: Add import blocks function to C header REVERT: 6b0ada2af42 kernel: Add chainstate load options for in-memory dbs in C header REVERT: 34427bfa9c7 kernel: Add options for reindexing in C header REVERT: ca57311c969 kernel: Add block validation to C header REVERT: 44156d84838 Kernel: Add chainstate loading to kernel C header REVERT: 2cee46cdcc1 kernel: Add chainstate manager object to C header REVERT: 7102c7ae45e kernel: Add notifications context option to C header REVERT: ed628a2a3c4 kerenl: Add chain params context option to C header REVERT: 27643297ff7 kernel: Add kernel library context object REVERT: 2ba22cf3f90 kernel: Add logging to kernel library C header REVERT: 873874c03e9 kernel: Introduce initial kernel C header API git-subtree-dir: libbitcoinkernel-sys/bitcoin git-subtree-split: 48158303fe276cb2f8fbc53ff31a4162d8f55c84

hebasto added the Build system label Oct 6, 2024

maflcko reviewed Oct 7, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

hebasto force-pushed the 241006-prefix branch from 5f5f3e8 to c87a9d2 Compare October 7, 2024 07:16

hebasto changed the title ~~build: Rename PACKAGE_* variables to BITCOIN_PACKAGE_*~~ build: Rename PACKAGE_* variables to CLIENT_* Oct 7, 2024

DrahtBot added CI failed and removed CI failed labels Oct 7, 2024

DrahtBot mentioned this pull request Oct 7, 2024

Add Signet and testnet4 launch shortcuts for Windows #26334

Merged

pablomartin4btc reviewed Oct 7, 2024

View reviewed changes

maflcko added the DrahtBot Guix build requested label Oct 8, 2024

DrahtBot added Needs rebase and removed DrahtBot Guix build requested labels Oct 8, 2024

hebasto force-pushed the 241006-prefix branch from c87a9d2 to 9777096 Compare October 11, 2024 10:32

hebasto marked this pull request as draft October 11, 2024 10:34

DrahtBot added the CI failed label Oct 11, 2024

hebasto force-pushed the 241006-prefix branch from 9777096 to 19cf191 Compare October 11, 2024 10:55

hebasto marked this pull request as ready for review October 11, 2024 10:58

DrahtBot removed CI failed Needs rebase labels Oct 11, 2024

hebasto force-pushed the 241006-prefix branch from 3ec5042 to 333c66f Compare October 24, 2024 13:59

DrahtBot added the CI failed label Oct 24, 2024

fanquake reviewed Oct 24, 2024

View reviewed changes

cmake/module/GenerateSetupNsi.cmake Show resolved Hide resolved

hebasto force-pushed the 241006-prefix branch from 333c66f to 36a3de0 Compare October 24, 2024 15:40

pablomartin4btc reviewed Oct 24, 2024

View reviewed changes

DrahtBot removed the CI failed label Oct 24, 2024

DrahtBot mentioned this pull request Oct 25, 2024

tinyformat: enforce compile-time checks for format string literals #31149

Closed

DrahtBot removed the DrahtBot Guix build requested label Oct 25, 2024

DrahtBot mentioned this pull request Oct 26, 2024

Cleanups to port mapping module post UPnP drop #31157

Open

TheCharlatan approved these changes Oct 26, 2024

View reviewed changes

hebasto force-pushed the 241006-prefix branch from 36a3de0 to 2076a08 Compare October 26, 2024 12:28

TheCharlatan approved these changes Oct 26, 2024

View reviewed changes

DrahtBot requested a review from pablomartin4btc October 26, 2024 12:37

DrahtBot added the Needs rebase label Oct 28, 2024

hebasto added 3 commits October 28, 2024 12:35

scripted-diff: Clarify "user agent" variable name

e6e29e3

This change allows to the use of the `CLIENT_` namespace without potential name clashes. -BEGIN VERIFY SCRIPT- sed -i "s/\<CLIENT_NAME\>/UA_NAME/g" $( git grep -l "CLIENT_NAME" ./src) -END VERIFY SCRIPT-

hebasto force-pushed the 241006-prefix branch from 2076a08 to 7071330 Compare October 28, 2024 12:36

TheCharlatan approved these changes Oct 28, 2024

View reviewed changes

DrahtBot removed the Needs rebase label Oct 28, 2024

fanquake merged commit 54c4b09 into bitcoin:master Oct 28, 2024
16 checks passed

hebasto deleted the 241006-prefix branch October 28, 2024 16:01

Sjors mentioned this pull request Nov 25, 2024

multiprocess: add bitcoin-mine test program #30437

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Rename `PACKAGE_` variables to `CLIENT_` #31042

build: Rename `PACKAGE_` variables to `CLIENT_` #31042

hebasto commented Oct 6, 2024 •

edited

Loading

DrahtBot commented Oct 6, 2024 •

edited

Loading

pablomartin4btc left a comment

hebasto commented Oct 8, 2024

DrahtBot commented Oct 8, 2024

DrahtBot commented Oct 11, 2024

hebasto commented Oct 24, 2024

DrahtBot commented Oct 24, 2024

pablomartin4btc left a comment

DrahtBot commented Oct 25, 2024

TheCharlatan left a comment

hebasto commented Oct 26, 2024

TheCharlatan left a comment

hebasto commented Oct 28, 2024

TheCharlatan left a comment

fanquake commented Oct 28, 2024

build: Rename PACKAGE_* variables to CLIENT_* #31042

build: Rename PACKAGE_* variables to CLIENT_* #31042

Conversation

hebasto commented Oct 6, 2024 • edited Loading

DrahtBot commented Oct 6, 2024 • edited Loading

Code Coverage

Reviews

Conflicts

pablomartin4btc left a comment

Choose a reason for hiding this comment

hebasto commented Oct 8, 2024

DrahtBot commented Oct 8, 2024

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

DrahtBot commented Oct 11, 2024

hebasto commented Oct 24, 2024

DrahtBot commented Oct 24, 2024

pablomartin4btc left a comment

Choose a reason for hiding this comment

DrahtBot commented Oct 25, 2024

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

TheCharlatan left a comment

Choose a reason for hiding this comment

hebasto commented Oct 26, 2024

TheCharlatan left a comment

Choose a reason for hiding this comment

hebasto commented Oct 28, 2024

TheCharlatan left a comment

Choose a reason for hiding this comment

fanquake commented Oct 28, 2024

build: Rename `PACKAGE_` variables to `CLIENT_` #31042

build: Rename `PACKAGE_` variables to `CLIENT_` #31042

hebasto commented Oct 6, 2024 •

edited

Loading

DrahtBot commented Oct 6, 2024 •

edited

Loading