Update about logo icon (colour) to denote the chain type of the QT instance in About/ Help Message Window/ Dialog #762

pablomartin4btc · 2023-09-25T00:03:25Z

It fixes #761.

About logo icon is updated now with the correct colour indicating the chain type of the QT instance that user is running (as the splash screen), plus the title of the about window also is updated with the chain type string as in the main window.

Before PR changes screenshot

After PR changes screenshot

Current splash screen screenshot

(this hasn't been touched, just to show consistency with this PR changes)

Tested it also with:

mainnet (no command line args after bitcoin-qt or bitcoin-qt -chain=main),
-regtest and
-testnet.

DrahtBot · 2023-09-25T00:03:27Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	hernanmarino
Stale ACK	BrandonOdiwuor

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#bitcoin/bitcoin/31072 (refactor: Clean up messy strformat and bilingual_str usages by ryanofsky)
#bitcoin/bitcoin/31042 (build: Rename PACKAGE_* variables to CLIENT_* by hebasto)
#bitcoin/bitcoin/30997 (build: Switch to Qt 6 by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

maflcko

It may help to show screenshots before and after

maflcko · 2023-10-05T14:03:26Z

src/qt/utilitydialog.cpp

+void HelpMessageDialog::setAboutWindowTitle(const NetworkStyle *networkStyle)
+{
+    QString aboutTitle = tr("About %1").arg(PACKAGE_NAME);
+    if ((networkStyle) && (Params().GetChainType() != ChainType::MAIN)) aboutTitle.append(" " + networkStyle->getTitleAddText());


Why would this be nullptr? Seems easier to use a reference that is never null?

I didn't want to touch src/qt/bitcoin.cpp:

gui/src/qt/bitcoin.cpp

Line 568 in db19a7e

HelpMessageDialog help(nullptr, gArgs.IsArgSet("-version"));

And I also needed to move where the networkStyle is initialised/ set before the HelpMessageDialog constructor:

gui/src/qt/bitcoin.cpp

Line 607 in db19a7e

QScopedPointer<const NetworkStyle> networkStyle(NetworkStyle::instantiate(Params().GetChainType()));

But I can do it if that's better.

pablomartin4btc · 2023-10-05T14:38:16Z

It may help to show screenshots before and after

Thanks for your review @MarcoFalke, the before screenshot is on the issue #761 but I can bring it here if that makes it clearer.

hernanmarino

tested ACK

pablomartin4btc · 2023-10-07T19:34:46Z

It may help to show screenshots before and after

@maflcko I've updated the description with your suggestion (copied @furszy's style from his PR #764, I find it less invasive for the reviewer)

MarnixCroes

tack 30c235b

src/qt/utilitydialog.cpp

BrandonOdiwuor

Concept ACK

BrandonOdiwuor

Tested ACK 30c235b

hebasto · 2024-02-12T14:00:55Z

@GBKS What do you think from a designer's point of view?

maflcko · 2024-02-12T14:13:15Z

Not sure. All info displayed on the About page is fixed details about the software itself, not about the current (test)chain. So modulating the icon or title bar seems confusing, but no strong opinion.

GBKS · 2024-02-15T12:30:24Z

Definitely more consistent this way.

hebasto · 2024-02-15T13:22:10Z

Not sure. All info displayed on the About page is fixed details about the software itself, not about the current (test)chain.

In that case, shouldn't the logo on the About page be black-toned?

pablomartin4btc · 2024-02-28T00:23:56Z

Not sure. All info displayed on the About page is fixed details about the software itself, not about the current (test)chain.

In that case, shouldn't the logo on the About page be black-toned?

I'm less sure about black-toned icons, in that specific case, it's more common usage I guess, users are already used to the orange one.

I think the most notable use case is when you have different instances open and you want to make sure you are standing on the correct one but more importantly the consistency regarding other components such as the splash screen and task-bar icons as pointed by @GBKS.

hebasto · 2024-05-15T17:56:07Z

#762 (comment):

Definitely more consistent this way.

Thank you @GBKS for your designer's opinion!

hebasto

If you will touch this branch, mind applying clang-format-diff.py?

src/qt/utilitydialog.h

pablomartin4btc · 2024-05-19T19:33:56Z

Updates:

Addressed @hebasto's feedback.

git diff -U0 HEAD~1.. | ./contrib/devtools/clang-format-diff.py -p1 -i -v
Formatting src/qt/bitcoingui.cpp
Formatting src/qt/utilitydialog.cpp
Formatting src/qt/utilitydialog.h

As part of the above, functions were re-placed in the private section (no in slots as mistaken).
As a consequence of applying the clang-formatting, @kristapsk's feedback got addressed as well.

hebasto

Tested 577d500.

On Windows, there remains some inconsistency. Running bitcoin-qt.exe -signet -about ends with a dialog with an orange-coloured icon.

src/qt/utilitydialog.cpp

pablomartin4btc · 2024-08-05T15:56:57Z

On Windows, there remains some inconsistency. Running bitcoin-qt.exe -signet -about ends with a dialog with an orange-coloured icon.

Let me take a look...

pablomartin4btc · 2024-08-08T16:51:08Z

On Windows, there remains some inconsistency. Running bitcoin-qt.exe -signet -about ends with a dialog with an orange-coloured icon.

Let me take a look...

Good catch... trying to get it sorted...

Adding the networkStyle parameter to the HelpMessageDialog creator on utilitydialog, updating all calls where its instance is being created from bitcoingui.cpp. In the object itself, use this new parameter object to build the about window title and set the icon of the about logo widget. Also, set th correct chain type icon at the very beginning of GuiMain() where command line arguments were validated and most of the app settings were not initialised yet.

pablomartin4btc · 2024-08-25T19:16:04Z

Updates:

Addressed @hebasto's feedback.
Fixed the error message window inconsistency detected by @hebasto above.

Now running qt from the command line with bitcoin-qt.exe -signet -about (or similar command with an invalid argument) will show the correct chain type icon at the top left of the title bar (this is only happening in Windows at the moment).

DrahtBot · 2024-10-28T17:50:31Z

🐙 This pull request conflicts with the target branch and needs rebase.

DrahtBot added CI failed and removed CI failed labels Sep 25, 2023

pablomartin4btc force-pushed the gui-update-about-logo-icon branch from 7398ef4 to 30c235b Compare September 25, 2023 02:21

maflcko reviewed Oct 5, 2023

View reviewed changes

hernanmarino approved these changes Oct 6, 2023

View reviewed changes

MarnixCroes approved these changes Nov 2, 2023

View reviewed changes

DrahtBot mentioned this pull request Nov 14, 2023

getrawtransaction implementation #777

Open

kristapsk reviewed Dec 27, 2023

View reviewed changes

src/qt/utilitydialog.cpp Outdated Show resolved Hide resolved

BrandonOdiwuor reviewed Dec 28, 2023

View reviewed changes

BrandonOdiwuor approved these changes Dec 28, 2023

View reviewed changes

DrahtBot requested review from hernanmarino and removed request for hernanmarino December 28, 2023 13:38

DrahtBot added the CI failed label Jan 14, 2024

DrahtBot requested review from hernanmarino and removed request for hernanmarino February 12, 2024 14:00

DrahtBot requested review from hernanmarino and removed request for hernanmarino February 12, 2024 14:13

maflcko mentioned this pull request Feb 13, 2024

About logo icon doesn't denote chain type (?) in About/ Help message window/ dialog #761

Open

1 task

DrahtBot requested review from hernanmarino and removed request for hernanmarino February 15, 2024 12:30

DrahtBot requested review from hernanmarino and removed request for hernanmarino February 15, 2024 13:22

DrahtBot requested review from hernanmarino and removed request for hernanmarino February 28, 2024 00:23

hebasto reviewed May 15, 2024

View reviewed changes

src/qt/utilitydialog.h Outdated Show resolved Hide resolved

pablomartin4btc force-pushed the gui-update-about-logo-icon branch from 30c235b to 577d500 Compare May 19, 2024 19:10

hebasto reviewed Aug 5, 2024

View reviewed changes

src/qt/utilitydialog.cpp Outdated Show resolved Hide resolved

src/qt/utilitydialog.cpp Outdated Show resolved Hide resolved

pablomartin4btc force-pushed the gui-update-about-logo-icon branch from 577d500 to 5556860 Compare August 25, 2024 19:02

DrahtBot removed the CI failed label Aug 25, 2024

This was referenced Oct 11, 2024

refactor: Clean up messy strformat and bilingual_str usages bitcoin/bitcoin#31072

Open

build: Rename PACKAGE_* variables to CLIENT_* bitcoin/bitcoin#31042

Merged

util: Check bilingual_str format strings at compile time bitcoin/bitcoin#31074

Closed

DrahtBot mentioned this pull request Oct 25, 2024

build: Switch to Qt 6 bitcoin/bitcoin#30997

Open

DrahtBot added the Needs rebase label Oct 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update about logo icon (colour) to denote the chain type of the QT instance in About/ Help Message Window/ Dialog #762

Update about logo icon (colour) to denote the chain type of the QT instance in About/ Help Message Window/ Dialog #762

pablomartin4btc commented Sep 25, 2023 •

edited by hebasto

Loading

DrahtBot commented Sep 25, 2023 •

edited

Loading

maflcko left a comment

maflcko Oct 5, 2023

pablomartin4btc Oct 5, 2023

pablomartin4btc commented Oct 5, 2023

hernanmarino left a comment

pablomartin4btc commented Oct 7, 2023

MarnixCroes left a comment

BrandonOdiwuor left a comment

BrandonOdiwuor left a comment

hebasto commented Feb 12, 2024

maflcko commented Feb 12, 2024

GBKS commented Feb 15, 2024

hebasto commented Feb 15, 2024

pablomartin4btc commented Feb 28, 2024

hebasto commented May 15, 2024

hebasto left a comment

pablomartin4btc commented May 19, 2024

hebasto left a comment

pablomartin4btc commented Aug 5, 2024

pablomartin4btc commented Aug 8, 2024

pablomartin4btc commented Aug 25, 2024

DrahtBot commented Oct 28, 2024

Update about logo icon (colour) to denote the chain type of the QT instance in About/ Help Message Window/ Dialog #762

Are you sure you want to change the base?

Update about logo icon (colour) to denote the chain type of the QT instance in About/ Help Message Window/ Dialog #762

Conversation

pablomartin4btc commented Sep 25, 2023 • edited by hebasto Loading

DrahtBot commented Sep 25, 2023 • edited Loading

Reviews

Conflicts

maflcko left a comment

Choose a reason for hiding this comment

maflcko Oct 5, 2023

Choose a reason for hiding this comment

pablomartin4btc Oct 5, 2023

Choose a reason for hiding this comment

pablomartin4btc commented Oct 5, 2023

hernanmarino left a comment

Choose a reason for hiding this comment

pablomartin4btc commented Oct 7, 2023

MarnixCroes left a comment

Choose a reason for hiding this comment

BrandonOdiwuor left a comment

Choose a reason for hiding this comment

BrandonOdiwuor left a comment

Choose a reason for hiding this comment

hebasto commented Feb 12, 2024

maflcko commented Feb 12, 2024

GBKS commented Feb 15, 2024

hebasto commented Feb 15, 2024

pablomartin4btc commented Feb 28, 2024

hebasto commented May 15, 2024

hebasto left a comment

Choose a reason for hiding this comment

pablomartin4btc commented May 19, 2024

hebasto left a comment

Choose a reason for hiding this comment

pablomartin4btc commented Aug 5, 2024

pablomartin4btc commented Aug 8, 2024

pablomartin4btc commented Aug 25, 2024

DrahtBot commented Oct 28, 2024

pablomartin4btc commented Sep 25, 2023 •

edited by hebasto

Loading

DrahtBot commented Sep 25, 2023 •

edited

Loading