Remove legacy wallet creation #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
@furszy Thank you! Concept ACK. |
hebasto
changed the title
furszy
force-pushed
the
2023_gui_remove_legacy_wallet_creation
branch
from
9702028
to
6b83663
Compare
|
It would be nice to have screenshots "before" and "after" in the PR description. |
hebasto
reviewed
Oct 6, 2023
furszy
force-pushed
the
2023_gui_remove_legacy_wallet_creation
branch
2 times, most recently
from
3336abb
to
038616b
Compare
hebasto
approved these changes
Oct 6, 2023
furszy
force-pushed
the
2023_gui_remove_legacy_wallet_creation
branch
from
038616b
to
b442580
Compare
|
Updated per Sjors's feedback. Thanks. |
pablomartin4btc
approved these changes
Oct 6, 2023
Comment on lines
+39
to
+45
| <item> | ||
| <widget class="QLabel" name="label_subdescription"> | ||
| <property name="text"> | ||
| <string>Please provide a name and, if desired, enable any advanced options</string> | ||
| </property> | ||
| </widget> | ||
| </item> |
There was a problem hiding this comment.
nit: is this not implicit? Perhaps we can set it as the tool-tip of the "Create" button? Also I think extracomment attribute for the <string> tag would be needed for the translation.
Suggested change
| <item> | |
| <widget class="QLabel" name="label_subdescription"> | |
| <property name="text"> | |
| <string>Please provide a name and, if desired, enable any advanced options</string> | |
| </property> | |
| </widget> | |
| </item> |
|
ACK b442580 |
|
re-ACK b442580 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #763
Preventing users from creating a legacy wallet prior to its deprecation in the upcoming releases.
Note:
This is still available using the
createwalletRPC command.Future Note:
Would be nice to re-write this modal as a wizard. And improve the design.
Pre-Changes Screenshot
Post-Changes Screenshot