Future-proofing for CUnit-derived class sizing #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprunk
commented
Jan 10, 2025
rts/Sim/Units/UnitMemPool.h
Outdated
| @@ -7,11 +7,15 @@ | |||
| #include "Sim/Misc/GlobalConstants.h" | |||
| #include "System/MemPoolTypes.h" | |||
|
|
|||
| /* Size asserted manually in UnitHandler.cpp (to avoid extra #includes here). | |||
| * TODO: would be good if this could be found automatically via metaprogramming */ | |||
| using LargestDerivedFromCUnit = CBuilder; | |||
There was a problem hiding this comment.
This will be the only line that needs changing in the future if a different type becomes larger.
|
I think it can be done like this: union LargestDerivedFromCUnit
{
CUnit unit;
CBuilder builder;
CFactory factory;
CBuilding building;
CExtractorBuilding extractorBuilding;
}; |
sprunk
force-pushed
the
largest-derived-from-cunit
branch
from
e2a584c to
ed18f16
Compare
saurtron
approved these changes
Jan 12, 2025
saurtron
added
the
status: candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from @saurtron's code and modified a bit.