Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SelectedUnitsHandler be a bit smarter about updating. #1825

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make SelectedUnitsHandler be a bit smarter about updating. #1825

wants to merge 4 commits into from

Conversation

saurtron
Copy link
Collaborator

@saurtron saurtron commented Dec 17, 2024 •
edited
Loading

Work done

  • Don't set selectionChanged or possibleCommandsChanged when nothing actually changed.

@saurtron saurtron changed the title Make SelectedUnitsHandler be a bit smarter about deciding when it needs to update. Make SelectedUnitsHandler be a bit smarter about updating. Dec 17, 2024
sprunk
sprunk reviewed Dec 17, 2024
View reviewed changes
rts/Game/SelectedUnitsHandler.cpp Outdated Show resolved Hide resolved
rts/Game/SelectedUnitsHandler.cpp Show resolved Hide resolved
@saurtron saurtron marked this pull request as ready for review December 26, 2024 09:54
@saurtron saurtron added the status: candidate PRs that should be good to go or important for next release label Jan 5, 2025
@saurtron saurtron force-pushed the selectedunitshandler-less-updates branch from 344ba8f to 9c22189 Compare January 9, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sprunk sprunk sprunk approved these changes

Assignees
No one assigned
Labels
status: candidate PRs that should be good to go or important for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saurtron @sprunk