Tests: add flightTime weapondef test

[saurtron]

Work done

• Add 'test_flighttime' test.
  • Tests the flightTime weaponDef by enabling and disabling it for some units and firing at targets
    • tests on corbuzz (lrpc), armrock and corstorm (rocket bots)
  • Also tests accuracy weaponDef since otherwise the lrpc wouldn't always hit

Test steps

• Open a game with map "Quicksilver Remake"
• Enter console command /runtests flighttime

Screenshots:

[keelefi]

I tested this and the test fails:

[Test Runner] =====RUNNING TESTS=====
Unit-, Feature- & Weapon-Def editing is enabled! 
[GlobalLosActionExecutor] global LOS toggled for all allyteams
Speed set to 5.0 [Player]
[Test Runner] ��FAIL����: weapondefs/test_flighttime.lua [621 frames] [4169 ms] | [string "LuaUI/Widgets/tests/weapondefs/test_flighttime.lua"]:82: assertion failed!

I think the problem is that the same parameter shouldAlive is used for both checks. In the first run, shouldAlive is true and therefore the check against the solar passes. However, on the second run shouldAlive is false as we expect the rocket bot to die (which it does), but the solar is still alive as nothing is hitting that.

[saurtron]

but the solar is still alive as nothing is hitting that.

the lrpc should be hitting the solar, I'll review and see what's going on.

[saurtron]

I think the problem is that the same parameter shouldAlive is used for both checks. In the first run, shouldAlive is true and therefore the check against the solar passes. However, on the second run shouldAlive is false as we expect the rocket bot to die (which it does), but the solar is still alive as nothing is hitting that.

Found the problem: #4099