Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't trigger drag events if there's no movement #16950

Merged
merged 1 commit into from
Dec 24, 2024
Merged

don't trigger drag events if there's no movement #16950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/bevy_picking/src/events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,14 +692,18 @@ pub fn pointer_events(

// Emit Drag events to the entities we are dragging
for (drag_target, drag) in state.dragging.iter_mut() {
let delta = location.position - drag.latest_pos;
if delta == Vec2::ZERO {
continue; // No need to emit a Drag event if there is no movement
}
let drag_event = Pointer::new(
pointer_id,
location.clone(),
*drag_target,
Drag {
button,
distance: location.position - drag.start_pos,
delta: location.position - drag.latest_pos,
delta,
},
);
commands.trigger_targets(drag_event.clone(), *drag_target);
Expand Down
Loading