Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't trigger drag events if there's no movement #16950

Merged
merged 1 commit into from
Dec 24, 2024
Merged

don't trigger drag events if there's no movement #16950

merged 1 commit into from
Dec 24, 2024
+5 −1

Conversation

mockersf
Copy link
Member

Objective

Solution

  • When position delta is zero, don't trigger Drag or DragOver events

Testing

  • tested with the code from the issue

@mockersf mockersf added the A-Picking Pointing at and selecting objects of all sorts label Dec 24, 2024
@mockersf mockersf added this to the 0.15.1 milestone Dec 24, 2024
@BenjaminBrienen BenjaminBrienen added C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 24, 2024
alice-i-cecile
alice-i-cecile approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix. I think that an epsilon might be warranted, but let's ship this very simple change and see if it resolves things.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 24, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 24, 2024
Merged via the queue into bevyengine:main with commit 4acb34e Dec 24, 2024
34 checks passed
pcwalton pushed a commit to pcwalton/bevy that referenced this pull request Dec 25, 2024
@mockersf @pcwalton
don't trigger drag events if there's no movement (bevyengine#16950)
a9491c1 
# Objective

- Fixes bevyengine#16571

## Solution

- When position delta is zero, don't trigger `Drag` or `DragOver` events

## Testing

- tested with the code from the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Picking Pointing at and selecting objects of all sorts C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15.1
Development

Successfully merging this pull request may close these issues.

Drag picking event fires on pointer up
3 participants
@mockersf @alice-i-cecile @BenjaminBrienen