Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vestigial helper functions for Commands and EntityCommands #16936

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

JaySpruce
Copy link
Contributor

@JaySpruce JaySpruce commented Dec 22, 2024

Objective

I believe these started as structs, back when that was how commands had to be implemented. Now they just hide implementation details.

Solution

Remove the helper functions and move each implementation into its respective method, except for the ones that actually reduce code duplication.

@JaySpruce JaySpruce changed the title Remove vestigial helper functions in commands/mod.rs Remove vestigial helper functions for Commands and EntityCommands Dec 22, 2024
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 22, 2024
@chescock chescock added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 23, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 24, 2024
Merged via the queue into bevyengine:main with commit 1669ca6 Dec 24, 2024
29 checks passed
@JaySpruce JaySpruce deleted the clean_commands branch December 24, 2024 03:46
pcwalton pushed a commit to pcwalton/bevy that referenced this pull request Dec 25, 2024
…bevyengine#16936)

## Objective

I believe these started as structs, back when that was how commands had
to be implemented. Now they just hide implementation details.

## Solution

Remove the helper functions and move each implementation into its
respective method, except for the ones that actually reduce code
duplication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants