Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_mb_genres config option. #3786

Merged
merged 3 commits into from
Oct 31, 2020
Merged

Add use_mb_genres config option. #3786

merged 3 commits into from
Oct 31, 2020

Conversation

aereaux
Copy link
Contributor

@aereaux aereaux commented Oct 29, 2020

Description

This is a followup for #3781, adding a config option.

Let me know if I did anything wrong or missed anything, this is my first time adding a config option.

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome; thanks for doing this! Here is a comment about locating the option in our existing MusicBrainz configuration "section."

docs/reference/config.rst Outdated Show resolved Hide resolved
docs/reference/config.rst Outdated Show resolved Hide resolved
beets/autotag/mb.py Outdated Show resolved Hide resolved
@aereaux
Copy link
Contributor Author

aereaux commented Oct 30, 2020

Thanks! Added.

@sampsyo
Copy link
Member

sampsyo commented Oct 31, 2020

Yay; looks perfect! Thank you!!

@sampsyo sampsyo merged commit b63b66a into beetbox:master Oct 31, 2020
@aereaux aereaux deleted the add_genres branch May 12, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants