Merge pull request #3786 from aereaux/add_genres

Add use_mb_genres config option.
beetbox · Oct 31, 2020 · b63b66a · b63b66a
2 parents 627005d + ceb046d
commit b63b66a
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 4 deletions.
diff --git a/beets/autotag/mb.py b/beets/autotag/mb.py
@@ -418,7 +418,7 @@ def album_info(release):
         info.media = first_medium.get('format')
 
     genres = release.get('genre-list')
-    if genres:
+    if config['musicbrainz']['genres'] and genres:
         info.genre = ';'.join(g['name'] for g in genres)
 
     info.decode()

diff --git a/beets/config_default.yaml b/beets/config_default.yaml
@@ -105,6 +105,7 @@ musicbrainz:
     ratelimit_interval: 1.0
     searchlimit: 5
     extra_tags: []
+    genres: no
 
 match:
     strong_rec_thresh: 0.04

diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -159,9 +159,11 @@ New features:
 * :doc:`/plugins/web`: add DELETE and PATCH methods for modifying items
 * :doc:`/plugins/lyrics`: Removed LyricWiki source (shut down on 21/09/2020).
 * Added a ``--plugins`` (or ``-p``) flag to specify a list of plugins at startup.
-* Use musicbrainz genre tag api to get genre information.  This currently
+* Use the musicbrainz genre tag api to get genre information.  This currently
   depends on functionality that is currently unreleased in musicbrainzngs.
-  See https://github.com/alastair/python-musicbrainzngs/pull/247 and
+  Once the functionality has been released, you can enable it with the
+  ``genres`` option inside the ``musicbrainz`` config.  See
+  https://github.com/alastair/python-musicbrainzngs/pull/247 and
   https://github.com/alastair/python-musicbrainzngs/pull/266 .
   Thanks to :user:`aereaux`.
 

diff --git a/docs/reference/config.rst b/docs/reference/config.rst
@@ -356,7 +356,6 @@ Sets the albumartist for various-artist compilations. Defaults to ``'Various
 Artists'`` (the MusicBrainz standard). Affects other sources, such as
 :doc:`/plugins/discogs`, too.
 
-
 UI Options
 ----------
 
@@ -721,6 +720,17 @@ above example.
 
 Default: ``[]``
 
+.. _genres:
+
+genres
+~~~~~~
+
+Use MusicBrainz genre tags to populate the ``genre`` tag.  This will make it a
+semicolon-separated list of all the genres tagged for the release on
+MusicBrainz.
+
+Default: ``no``
+
 .. _match-config:
 
 Autotagger Matching Options