Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a partial symlink tree of the NDK rather than symlinking just … #14

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

ahumesky
Copy link
Collaborator

…the toolchains directory, to avoid creating BUILD files in the real NDK directories. Fixes #3.

…the `toolchains` directory, to avoid creating BUILD files in the real NDK directories. Fixes #3.
@keith
Copy link
Member

keith commented Sep 13, 2022

Assuming the CI update has been pushed on the bazel side the failure here is because it's still looking at the old NDK dir, but I can probably look at that separately if you want

@ahumesky
Copy link
Collaborator Author

sounds like we won't be able to get this to pass on mac for a bit (bazelbuild/continuous-integration#1434 (comment)) but it would be good to get this to pass at least on linux on CI before merging, so please feel free!

@keith
Copy link
Member

keith commented Sep 13, 2022

you can merge this one if it's good locally i'd say and I can work on another PR

@ahumesky
Copy link
Collaborator Author

ahumesky commented Sep 13, 2022

I set this up: #15 so perhaps that's enough to get at least linux working
(and this: 254cb3b)

@ahumesky
Copy link
Collaborator Author

Looks like NDK 25b is set up and it's getting picked up, but now the test is failing like this:
https://buildkite.com/bazel/rules-android-ndk/builds/9#01833901-70f1-44a2-b9ee-8d5ad5c57119/222-245

I believe that's because the ci is set up to test //... in the example directory, which would pick up the cc_library as a top-level target, which means it's also getting built in the top-level configuration which doesn't have the android configuration set up by the transition in android_binary. I'll just list the target specifically for now

@ahumesky
Copy link
Collaborator Author

This managed to pass on linux:
https://buildkite.com/bazel/rules-android-ndk/builds/10#01833910-40d4-4aa7-b1e6-18a9a459e03c/222-235

so that will have to be good enough for now

@ahumesky ahumesky merged commit db29e82 into bazelbuild:main Sep 13, 2022
@ahumesky ahumesky mentioned this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't create BUILD files in the NDK installation directory
3 participants