-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up presubmit tests #12
Comments
The terraform changes in bazelbuild/continuous-integration#1425 should solve this, it will create a pipeline for this, someone will have to hook up webhooks though |
I have set up the webhook, the presubmit is available for PRs now, see #13 and https://buildkite.com/bazel/rules-android-ndk/builds/2 But there are some failures, it looks like you are trying to put a BUILD file in the Android SDK installation directory? On Bazel CI, that directory is mounted in the docker container from the host VM, so it's not writable. Is there a way to avoid doing that? |
Until the postsubmit is green, see bazelbuild/rules_android_ndk#12 (comment)
Until the postsubmit is green, see bazelbuild/rules_android_ndk#12 (comment)
That the rule is incidentally creating build files in the real NDK directory is a known issue: #3 I'll work on solving that next |
Looks like we'll also need to update the version of the NDK on CI: |
Presubmit should now work for linux: It may take some time for mac to be set up Some commits in the course of setting this up: |
I think we're all good here |
it would be good to also run the apk that's built on an emulator, to make sure the artifact actually works, something like what's done here: but that can be its own issue |
Until the postsubmit is green, see bazelbuild/rules_android_ndk#12 (comment)
At minimum they should build the example app (https://github.com/bazelbuild/rules_android_ndk/tree/main/examples/basic) and ideally the resulting apk would be tested on an emulator / virtual device.
See also
#7
bazelbuild/continuous-integration#1425
This might be useful as inspiration too:
https://github.com/DanAlbert/ndk-app-template/blob/main/.github/workflows/build.yml
The text was updated successfully, but these errors were encountered: