-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/migrate new npm plugin (shows information for entities from npmjs.com) #1485
Conversation
Unnecessary ChangesetsThe following package(s) are private and do not need a changeset:
Changed Packages
|
@BethGriggs @nickboldt @Fortune-Ndlovu @ciiay I created this plugin some time ago in the evening. I will check asynchronously if I'm allowed to mark it as an RH plugin (in the plugin package.json). I will also add dynamic plugin support as a follow-up. Let me know if anything else is needed, missed or recommended. :) |
87190b6
to
e83339d
Compare
I've added api reports (and docs) and knip reports. Let's see what's missing next. =) |
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
9785420
to
59488d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the last thing to do is to create a changeset for @backstage-community/plugin-npm
to do a patch bump - this is needed to start the release flow. You can generate the changeset using yarn changeset
in the workspace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workspaces/npm/plugins/npm/src/components/NpmReleaseTableCard.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Christoph Jerolimov <[email protected]>
…r errors Signed-off-by: Christoph Jerolimov <[email protected]>
Thanks @BethGriggs and @karthikjeeyar for the review. I addressed all your comments.
Here is a recording how the errors are displayed: Screencast.from.2024-10-10.10-52-07.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Refs: backstage/community#160 |
Hey, I just made a Pull Request!
This PR adds a new workspace and plugin to show information from npm. From the plugin README:
Npm info card:
Npm release overview card:
Extended catalog entity overview tab (example):
New catalog entity npm release tab:
How to test the PR
The workspace contains a backstage app with working catalog entities:
✔️ Checklist
Signed-off-by
line in the message. (more info)