Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): switch to workspace dependency ref and add another code owner #1507

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix(npm): switch to workspace dependency ref and add another code owner #1507

merged 2 commits into from
Oct 10, 2024

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Oct 10, 2024 •
edited
Loading

Hey, I just made a Pull Request!

Follow up on #1485

  1. fix that the release process fails because it touches the backstage app, see PR Version Packages (npm) #1506
  2. add @karthikjeeyar as another codeowner 🤗

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@christoph-jerolimov christoph-jerolimov requested a review from a team as a code owner October 10, 2024 12:00
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/npm/packages/app none v0.0.0

@christoph-jerolimov christoph-jerolimov changed the title fix(npm): switch to workspace dependency ref fix(npm): switch to workspace dependency ref and add another code owner Oct 10, 2024
@christoph-jerolimov christoph-jerolimov mentioned this pull request Oct 10, 2024
Merged
@BethGriggs BethGriggs merged commit 19d4ffc into backstage:main Oct 10, 2024
12 checks passed
@christoph-jerolimov christoph-jerolimov deleted the fix-npm-workspace-ref branch October 10, 2024 12:13
@christoph-jerolimov christoph-jerolimov mentioned this pull request Oct 15, 2024
Closed
1 task
@christoph-jerolimov christoph-jerolimov self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/community-plugins-maintainers

Assignees

@christoph-jerolimov christoph-jerolimov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christoph-jerolimov @BethGriggs