Implement new and improved terraform-base deployment

[frrist]

Documentation: https://www.notion.so/expanso/Demo-Marketplace-Deployment-10136faf7b424425bc74acbf647b9606

[simonwo]

This broadly looks good to me... will this mean we have new two terraform folders now? terraform and tf? Are we aiming to replace the former?

[frrist]

will this mean we have new two terraform folders now? terraform and tf?

I think it depends. The features we have in our deployments to development/staging/production are specific to our needs as operators of a public network. e.g. limiting the HTTP endpoints jobs can query when executed by a compute node, promtail agent, ipfs running as a separate service, pre-defined IP addresses (for DNS), hard-coded network size, lack of auth, etc.

The terraform in tf which will be used for marketplace deployments doesn't/cannot have some of these custom things.

I think the ideal scenario would be us using the same code for our networks as users use for MP deployments, perhaps we can merge these things together in the future? WDYT?

[simonwo]

Yes, I think in the future it would be nice to use one as a base for the other. But we can work forward to that from here.

Maybe a more descriptive folder name would be good? I.e. marketplace or something?

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[frrist]

Maybe a more descriptive folder name would be good? I.e. marketplace or something?

Done. merging once CI passes.