feat: updated the date time to support timezone #2820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chandru-HM
force-pushed
the
feat/timezone-support-update
branch
from
ee5a409 to
8c90912
Compare
Chandru-HM
force-pushed
the
feat/timezone-support-update
branch
7 times, most recently
from
73df502 to
e62b70b
Compare
Chandru-HM
force-pushed
the
feat/timezone-support-update
branch
from
e62b70b to
dbbbdd6
Compare
jmbuss
reviewed
May 29, 2024
| initialTrendCursorDateString | ||
| .split('\n') | ||
| .join('T') | ||
| .replace(/(\d+)\/(\d+)\/(\d+)/, '$3-$2-$1') |
There was a problem hiding this comment.
does the date-fns library not support this?
There was a problem hiding this comment.
supports. updated.
| return ( | ||
| <DateTime | ||
| dateTime={ | ||
| Number(round(latestValueTime, significantDigits)) * 1000 |
| return ( | ||
| <div className='base-chart-legend-tc-header-container'> | ||
| <div> | ||
| <span>{date.toLocaleDateString()}</span> | ||
| <span>{dateTime.split(' ')[0]}</span> |
There was a problem hiding this comment.
Ca we use the date-fns formatter here?
Chandru-HM
force-pushed
the
feat/timezone-support-update
branch
from
dbbbdd6 to
5bf6c31
Compare
Chandru-HM
force-pushed
the
feat/timezone-support-update
branch
from
5bf6c31 to
443c847
Compare
corteggiano
force-pushed
the
rc
branch
2 times, most recently
from
87b7994 to
baad335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for ticket #2663 and added the timezone support for the date and time in xy-plot, KPI, and resource explorer
Verifying Changes
changes are not changing anything, date-time values are now adjusted to the timezone.
Legal
This project is available under the Apache 2.0 License.