feat: timezone support via get time offset #2680
Conversation
Chandru-HM
force-pushed
the
feat/timezone-support
branch
from
c7adc6a to
b849b13
Compare
Chandru-HM
force-pushed
the
feat/timezone-support
branch
2 times, most recently
from
ac855e0 to
e2db458
Compare
| ) : ( | ||
| <DateTime | ||
| dateTime={point.x} | ||
| pattern='dd/MM/yyyy, HH:mm:ss' |
There was a problem hiding this comment.
Can we make these constants? I believe this exists already here - packages/react-components/src/utils/time.ts
There was a problem hiding this comment.
Also, let's default the DateTime componeent to this so we don't need to pass it everywhere.
There was a problem hiding this comment.
Done.
Now the default pattern is 'M/d/yy HH:mm:ss' and created a constant ('dd/MM/yyyy, hh:mm:ss' ) as you mentioned to use in react-components.
| creationDate ? getFormattedDateTime(creationDate) : '-', | ||
| creationDate ? ( | ||
| <DateTime | ||
| dateTime={creationDate.getTime()} |
There was a problem hiding this comment.
Is it possible to change creationDate to a number prop? I don't think we should do a bunch of conversions number -> date -> number ->date. I think all of the places we have dates (except for probably viewport) should start as numbers.
Chandru-HM
force-pushed
the
feat/timezone-support
branch
8 times, most recently
from
f1a813d to
3e37408
Compare
Chandru-HM
force-pushed
the
feat/timezone-support
branch
2 times, most recently
from
3653a6a to
9fcc3a5
Compare
Chandru-HM
force-pushed
the
feat/timezone-support
branch
from
9fcc3a5 to
2fc28b2
Compare
Chandru-HM
force-pushed
the
feat/timezone-support
branch
4 times, most recently
from
4dc5fb2 to
ae7894d
Compare
Chandru-HM
force-pushed
the
feat/timezone-support
branch
2 times, most recently
from
d64030b to
720dc54
Compare
Chandru-HM
force-pushed
the
feat/timezone-support
branch
from
720dc54 to
dd433f8
Compare
Chandru-HM
force-pushed
the
feat/timezone-support
branch
from
dd433f8 to
154ea32
Compare
|
closed this PR due to many conflicts from the back merge. created the new one for the same #2820 |
This PR is for ticket #2663 and added the timezone support via get time offset.
Verifying Changes
timezone-support.mov
Legal
This project is available under the Apache 2.0 License.