test: avoid using unstable API from insta #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/insta-stable
branch
from
3ee201c
to
7519bd0
Compare
WesleyRosenblum
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We were previously depending on an unstable API from insta to override how snapshots were stored. This avoids this API by using the
insta::Settingsconfiguration to avoid the need.Call-outs:
The snapshot names did have to change due to how we're resolving the name. But I actually think it's a bit cleaner, since it doesn't include the crate name, which is a bit redundant.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.