You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
just bumped from 1.40.0 to 1.41.0 and introduced a breaking change to the assert_snapshot macro.
This results in compiler error when compiling s2n-quic-core:
error[E0277]: the trait bound `SnapshotValue<'_>: From<AutoName>` is not satisfied
--> /redacted/.cargo/registry/src/index.crates.io-6f17d22bba15001f/s2n-quic-core-0.47.0/src/event/generated.rs:8832:49
|
8832 | insta::_macro_support::AutoName.into(),
| ^^^^ the trait `From<AutoName>` is not implemented for `SnapshotValue<'_>`, which is required by `AutoName: Into<_>`
|
= help: the following other types implement trait `From<T>`:
<SnapshotValue<'a> as From<(&'a str, &'a str)>>
<SnapshotValue<'a> as From<(AutoName, &'a str)>>
<SnapshotValue<'a> as From<(InlineValue<'a>, &'a str)>>
<SnapshotValue<'a> as From<(Option<&'a str>, &'a str)>>
<SnapshotValue<'a> as From<(Option<std::string::String>, &'a str)>>
<SnapshotValue<'a> as From<(std::string::String, &'a str)>>
<SnapshotValue<'a> as From<BinarySnapshotValue<'a>>>
= note: required for `AutoName` to implement `Into<SnapshotValue<'_>>`
error[E0061]: this function takes 7 arguments but 8 arguments were supplied
--> /home/tracy/.cargo/registry/src/index.crates.io-6f17d22bba15001f/s2n-quic-core-0.47.0/src/event/generated.rs:8831:13
|
8831 | insta::_macro_support::assert_snapshot(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
8832 | insta::_macro_support::AutoName.into(),
8833 | &value,
| ------
| |
| unexpected argument of type `&std::string::String`
| an argument of type `&std::path::Path` is missing
...
8839 | "",
| -- unexpected argument of type `&'static str`
|
Solution:
There are two options:
Pin the version of insta required in [dependencies] and [dev-dependencies] for s2n-quic-core to 1.40.0
Update the use of the insta crate to be compliant with the latest "minor" version bump that introduces breaking API changes
Does this change what s2n-quic sends over the wire? No
Does this change any public APIs? No
Requirements / Acceptance Criteria:
N/A
Out of scope:
N/A
The text was updated successfully, but these errors were encountered:
Problem:
The insta dependency defined here:
just bumped from
1.40.0
to1.41.0
and introduced a breaking change to theassert_snapshot
macro.This results in compiler error when compiling s2n-quic-core:
Solution:
There are two options:
insta
required in[dependencies]
and[dev-dependencies]
for s2n-quic-core to1.40.0
insta
crate to be compliant with the latest "minor" version bump that introduces breaking API changesRequirements / Acceptance Criteria:
N/A
Out of scope:
N/A
The text was updated successfully, but these errors were encountered: