Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processing_time_visualizer): enable to wait until topic published #97

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Aug 15, 2024

Description

Within current implementation, the desired topic should be published before the visualizer activation. Otherwise we get following error, or can not list full topics.

[INFO 1723732920.532605343] [processing_time_visualizerde495974_29bb_4bbc_803f_a22aae0053b8]: No ProcessingTimeTree topic found (subscribe_processing_time_tree() at /home/yoshiri/autoware/build/autoware_debug_tools/autoware_debug_tools/processing_time_visualizer/node.py:83)
[INFO 1723732920.532896897] [processing_time_visualizerde495974_29bb_4bbc_803f_a22aae0053b8]: Exiting... (subscribe_processing_time_tree() at /home/yoshiri/autoware/build/autoware_debug_tools/autoware_debug_tools/processing_time_visualizer/node.py:84)
[ros2run]: Process exited with failure 1

This PR enables visualizer to wait X seconds until the objective topic will published.

sample usage:

# wait for 10sec
 ros2 run autoware_debug_tools processing_time_visualizer -w 10

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@YoshiRi YoshiRi requested a review from yhisaki August 15, 2024 14:48
@YoshiRi YoshiRi self-assigned this Aug 15, 2024
Copy link
Contributor

@yhisaki yhisaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants