-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lanelet2_map_validator): check whether intersection_area satisfies vm-03-08 #171
Merged
TaikiYamada4
merged 13 commits into
autowarefoundation:main
from
TaikiYamada4:feat/lanelet2_map_validator/intersection_area_validation
Dec 17, 2024
Merged
feat(lanelet2_map_validator): check whether intersection_area satisfies vm-03-08 #171
TaikiYamada4
merged 13 commits into
autowarefoundation:main
from
TaikiYamada4:feat/lanelet2_map_validator/intersection_area_validation
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
TaikiYamada4
requested review from
anhnv3991,
soblin,
Motsu-san,
SakodaShintaro and
YamatoAndo
as code owners
December 10, 2024 09:43
TaikiYamada4
added
tag:run-build-and-test-differential
and removed
tag:run-build-and-test-differential
labels
Dec 10, 2024
…rary Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
satoshi-ota
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
soblin
approved these changes
Dec 17, 2024
TaikiYamada4
deleted the
feat/lanelet2_map_validator/intersection_area_validation
branch
December 17, 2024 09:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds validators to
autoware_lanelet2_map_validator
whether the lanelet2 map satisfies the map requirementvm-03-08
written in Autoware Documentation.Two validators are added to achieve this goal.
mapping.intersection.intersection_area_validity
intersection_area
polygon satisfiesboost::geometry::is_valid
.mapping.intersection.intersection_area_segment_type
intersection_area
polygon consists of onlyroad_border
type linestrings and starting/ending edges of lanelets.In short, this PR adds the following implementation
mapping.intersection.intersection_area_validity
mapping.intersection.intersection_area_segment_type
mapping.intersection.intersection_area_validity
andmapping.intersection.intersection_area_segment_type
mapping.intersection.intersection_area_validity
andmapping.intersection.intersection_area_segment_type
autoware_requirement_set.json
Related links
Map requirement
vm-03-08
Tests performed
colcon test --packages-select autoware_lanelet2_map_validator --event-handlers console_cohesion+
passes.Notes for reviewers
In the test code I've only made a test map to detect self-intersections and wrong orientations. Please let me know if there are other error modes to be tested.
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.