-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update acceleration limit #1181
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Berkay Karaman <[email protected]>
Signed-off-by: Berkay Karaman <[email protected]> #1181
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that this PR is too specific to Dense Urban ODD. Can I ask you to reconsider?
@@ -11,7 +11,7 @@ | |||
|
|||
# constraints to be observed | |||
limit: | |||
min_acc: -2.5 # min deceleration limit [m/ss] | |||
min_acc: -2.49 # min deceleration limit [m/ss] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change may be only for Dense Urban ODD.
@@ -53,7 +53,7 @@ | |||
|
|||
# stopped state | |||
stopped_vel: 0.0 | |||
stopped_acc: -3.4 # denotes pedal position | |||
stopped_acc: -2.49 # denotes pedal position |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stopped_acc does not denote deceleration value, but denotes pedal position after the stop has achieved.
Hence this change is not required.
max_acc: 3.0 | ||
min_acc: -5.0 | ||
max_acc: 1.5 | ||
min_acc: -2.49 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to follow the trajectory planned with limit.min_acc
and limit.max_acc
in the planning params, this values must be greater than planning params. Because we need a margin for disturbance and error.
However, I think we have an option to align these values to the limit.min_acc
and limit.max_acc
in common.pram.yaml to restrict the feedback control.
@Igata-ctrl @mitsudome-r what should be done about this PR? @brkay54 won't be able to work on this task anymore. But how should we handle scenarios and parameters like these? Are there other scenarios that the public cannot access? I think the autoware_launch default parameters should be tuned for scenarios that are accessible by the public. |
Description
Following the recent discussions in the ODD Working Group, we've agreed to set the deceleration limit to 0.255G (~2.499 m/s²) for Dense Urban ODD. To implement this change, we need to update the acceleration limit parameters on both the planning and control sides.
For more details, refer to the ODD WG Discussion page: ODD WG Discussion #5290
Tests performed
I tested Dense Urban ODD scenarios in the local.
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.