Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: awsim_labs velodyne_top_base_link yaw value #51

Closed

Conversation

mozhoku
Copy link
Contributor

@mozhoku mozhoku commented May 24, 2024

Description

Fix AWSIM Labs sensor kit, "velodyne_top_base_link" yaw value.

Reason for this change:

When we are importing vehicle sensor config that generated from the Autoware to the Unity with our Dynamic Sensor Placement tool the vehicle localizes with a 90 degree error.
To prevent this, I've changed velodyne_top_base_link yaw value to "0". Since it shouldn't have a rotation difference from the "sensor_kit_base_link"

Related Links

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mozhoku
Copy link
Contributor Author

mozhoku commented May 24, 2024

After looking into this with @xmfcx he noticed that top lidars Frame ID is "sensor_kit_base_link". We will change this ID to top lidars base_link in the vehicle prefab. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants