Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ansible): update role readme files #5443

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Nov 17, 2024

Description

This PR updates the README.md files of the following roles:

  • cuda
    • Update the link to point to cuda 12.3
    • add driver version compatibility information and instructions
    • add cuda-drivers-545 line
    • replace cuda with cuda-toolkit
  • dev_tools
    • fix input variable names
    • manual installation
      • add line for retrieving env vars automatically
      • reorder the items for ease of installation
      • add python3-pip (as it doesn't come in a fresh ubuntu 22.04 installation)
  • tensorrt
    • remove redundant lines
    • reorder for ease of installation
    • update link description

Tests performed

Followed them on my machine (after doing a fresh installation).

Effects on system behavior

By having the compatible nvidia-driver version, the systems should run more stable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx requested a review from mitsudome-r November 17, 2024 16:18
@xmfcx xmfcx self-assigned this Nov 17, 2024
@xmfcx xmfcx added the tag:run-health-check Run health-check label Nov 17, 2024
@xmfcx xmfcx merged commit d1cae7e into main Nov 18, 2024
20 of 21 checks passed
@xmfcx xmfcx deleted the docs/ansible-readme-updates branch November 18, 2024 09:01
@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 18, 2024

Thx for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants