Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add universe_dbw_bridge package #3935

Closed

Conversation

DeeKayG
Copy link

@DeeKayG DeeKayG commented Oct 25, 2023

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Author

@DeeKayG DeeKayG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added DBW Bridge with feedback

@xmfcx xmfcx changed the title Added DBW Bridge to new Branch feat: add universe_dbw_bridge package Nov 15, 2023
@xmfcx
Copy link
Contributor

xmfcx commented Nov 15, 2023

Hello @DeeKayG and welcome to the Autoware project!

I know it's a bit un-intuitive but when creating a new PR, you should click on "Small change" or "Standard change" and fill in the information.
More info can be found in here: https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/#example

I've pasted in the small change option and edited your PR, you don't need to do this anymore for this PR.
You can edit the description now.

Could you rename your first commit message to feat: add universe_dbw_bridge package please?

@xmfcx
Copy link
Contributor

xmfcx commented Nov 15, 2023

Hmm I was confused for a moment, this change should be proposed into https://github.com/autowarefoundation/autoware.universe not here. Could you create this PR targeting there please?

The reason:

@xmfcx xmfcx closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants