Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add traffic control ui #17

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

mozhoku
Copy link
Collaborator

@mozhoku mozhoku commented Mar 13, 2024

Issue:

With this addition the traffic manager can be partially controlled from the Main Menu (esc).
image

@mozhoku mozhoku self-assigned this Mar 13, 2024
@mozhoku mozhoku added the type:new-feature New functionalities or additions, feature requests. label Mar 13, 2024
@mozhoku mozhoku requested a review from xmfcx March 13, 2024 13:56
@xmfcx xmfcx changed the title feat: Traffic Control UI feat: add traffic control ui Mar 13, 2024
@xmfcx xmfcx marked this pull request as draft March 13, 2024 14:14
@mozhoku
Copy link
Collaborator Author

mozhoku commented Mar 14, 2024

image

Camera output is overlapping the UI. Currently, this can be adjusted by scaling it or disabling it through the inspector. However, ideally, the camera output should be drawn behind the UI elements. To achieve this, I need to modify the rendering process to ensure the camera output is drawn in the correct order. Additionally, if there were multiple cameras, they could potentially obstruct the view on the screen.

I'll create a separate issue for this later on.

@mozhoku
Copy link
Collaborator Author

mozhoku commented Mar 14, 2024

This is how it looks at the moment:
https://youtu.be/P5qCVeOA-jI

@mozhoku mozhoku marked this pull request as ready for review March 15, 2024 09:05
@xmfcx
Copy link

xmfcx commented Mar 15, 2024

Thanks for the updates, looks promising 🍀

Could you create an issue and a PR to put the Camera panels behind the Main Menu canvas?

@mozhoku mozhoku force-pushed the feat/traffic-control-ui branch 3 times, most recently from b19f0ff to ca96dbc Compare March 28, 2024 09:51
Signed-off-by: Alptuğ Cırıt <[email protected]>
@mozhoku mozhoku force-pushed the feat/traffic-control-ui branch from ca96dbc to 656daed Compare March 28, 2024 10:38
Signed-off-by: Alptuğ Cırıt <[email protected]>
@xmfcx
Copy link

xmfcx commented Mar 28, 2024

Screenshot from 2024-03-28 13-49-56

Works well!

@xmfcx xmfcx merged commit a0633ab into autowarefoundation:main Mar 28, 2024
3 of 4 checks passed
@mozhoku mozhoku deleted the feat/traffic-control-ui branch May 2, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants