Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temp way to update default scene spawn points in the loader ui #164

Merged

Conversation

mozhoku
Copy link
Collaborator

@mozhoku mozhoku commented Sep 27, 2024

Description

Temporary fix requested by @xmfcx . This PR updates the Loader UI spawn coordinates to the selected scenes coordinates. These points are Scene name specific and updated by hand in the MapManager.cs script as for now.

Related links

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mozhoku mozhoku added the type:enchantment Improve existing feature label Sep 27, 2024
@mozhoku mozhoku requested a review from xmfcx September 27, 2024 05:48
@mozhoku mozhoku self-assigned this Sep 27, 2024
@mozhoku mozhoku added the type:bug Software flaws or errors. label Sep 27, 2024
@mozhoku mozhoku marked this pull request as ready for review September 27, 2024 05:48
@xmfcx xmfcx merged commit 6aa55b1 into autowarefoundation:main Sep 27, 2024
9 of 12 checks passed
@mozhoku mozhoku deleted the fix/auto-update-spawn-points-for-scenes branch October 3, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Software flaws or errors. type:enchantment Improve existing feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants