-
-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blog): add release notes for 2.4 release #634
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
/au |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me!
|
||
This new feature was contributed by [Daniel Kocot](https://github.com/danielkocot). For more detail, see this [pull request](https://github.com/asyncapi/spec/pull/717) and the [Github issue where this change was discussed](https://github.com/asyncapi/spec/issues/707). | ||
|
||
## Security can now be defined at Operation level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sekharbans-ebay would you like to review the release notes I wrote here about your recent contribution? Also check the example in detail, please.
Thanks!
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-634--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left my review @smoya 😸
As usual, terrific review @alequetzalli. I always learn a lot from them! Thanks! |
Co-authored-by: Alejandra Quetzalli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌈 ⭐ 🌟
6dc94a4
- auth:read | ||
``` | ||
|
||
Thanks to [Sekharbans](https://github.com/sekharbans-ebay), is now possible to increase security granularity by defining a set of security requirements at Operation level. For more detail, see [Sekharban's `/spec #584` pull request](https://github.com/asyncapi/spec/pull/584) and the [Github issue where Sekharban's suggested feature was discussed](https://github.com/asyncapi/spec/issues/584). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alequetzalli I added those two lines as I missed adding the link to the PR and Issue on this feature.
Would you mind giving a check and +1 if you agree please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why limit to a +1 when I can do an APPROVE PR STAT
😸
Netlify build failed. @fmvilas @derberg can you relaunch it? |
Co-authored-by: Lukasz Gornicki <[email protected]>
@alequetzalli I merged without waiting for your final ✅ as all changes added by @smoya were purely technical 🙏🏼 |
Description
This pull request is a placeholder draft of the release notes for the upcoming 2.4 release.
Contributes to: asyncapi/spec#735