Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on 2.4 release #735

Closed
54 of 55 tasks
smoya opened this issue Mar 14, 2022 · 11 comments
Closed
54 of 55 tasks

Work on 2.4 release #735

smoya opened this issue Mar 14, 2022 · 11 comments

Comments

@smoya
Copy link
Member

smoya commented Mar 14, 2022

Release 2.4.0 is scheduled for April 2022

Detailed info:

Kick-off:

Release branches:

Release notes:

Progress:

Cleanup tasks for this particular version

Potential work to be included in this version

Accepted

Pending

Discarded

@smoya
Copy link
Member Author

smoya commented Mar 15, 2022

I wonder if we would want to build the changes on our JSON Schema files based on asyncapi/spec-json-schemas#128.

Such change is a breaking change for the spec-json-schemas repository (that's why it was merged into next-major). It is considered a breaking change because $id field values are completely changed now.
That means any tool that depends explicitly on those $id will break. That includes parser-js. BTW, the "fix" is short: https://github.com/asyncapi/parser-js/pull/423/files.

Would it make sense to release spec-json-schemas new major version (including the split schemas) and build the changes required for spec 2.4.0 on top of it? I would say yes. The new minor version we will release for the parser-js could point to the major spec-json-schemas release.

Is there anything else I'm missing that stop us from doing that?

cc @derberg @jonaslagoni

@smoya
Copy link
Member Author

smoya commented Mar 21, 2022

I wonder if we would want to build the changes on our JSON Schema files based on asyncapi/spec-json-schemas#128.

Such change is a breaking change for the spec-json-schemas repository (that's why it was merged into next-major). It is considered a breaking change because $id field values are completely changed now. That means any tool that depends explicitly on those $id will break. That includes parser-js. BTW, the "fix" is short: https://github.com/asyncapi/parser-js/pull/423/files.

Would it make sense to release spec-json-schemas new major version (including the split schemas) and build the changes required for spec 2.4.0 on top of it? I would say yes. The new minor version we will release for the parser-js could point to the major spec-json-schemas release.

Is there anything else I'm missing that stop us from doing that?

cc @derberg @jonaslagoni

As it seems there are no cons for building on top of the new definitions structure, we will do once asyncapi/spec-json-schemas#184 is merged.

@smoya
Copy link
Member Author

smoya commented Mar 21, 2022

I'm keeping a list in the description of the issue with the potential work to be included in this release.

@smoya
Copy link
Member Author

smoya commented Mar 30, 2022

Would it make sense to release spec-json-schemas new major version (including the split schemas) and build the changes required for spec 2.4.0 on top of it? I would say yes. The new minor version we will release for the parser-js could point to the major spec-json-schemas release.

For this version, we are gonna keep working with the current schemas structure (master branch). More info here: asyncapi/spec-json-schemas#184

@smoya
Copy link
Member Author

smoya commented Apr 26, 2022

Complementing https://asyncapi.slack.com/archives/CQVJXFNQL/p1650543345479079

The AsyncAPI spec 2.4.0 release is gonna happen between tomorrow and the day after approx.
All features have been merged and are available under prereleases.

Those are the merged features:

I’m pinging code owners of the repositories affected so you can start preparing the needed updates:

@derberg @magicmatatjahu @fmvilas @jonaslagoni @dalelane @M3lkior @Souvikns @boyney123 @arjungarg07 @AGurlhosur @dan-r @KieranM1999 @lewis-relph @JEFFLUFC @KhudaDad414 @smoya @BOLT04 @NektariosFifes @mcturco

EDIT:

I think I wasn’t pretty clear with this message. Dependencies are bumped automatically by CI/CD automation once the release happens.
Only some critical projects will need to do some extra work:

I added the clarification in the RELEASE_PROCESS.md file so this doesn’t happen again: #770

@smoya
Copy link
Member Author

smoya commented Apr 27, 2022

Starting the release process right now cc @derberg @dalelane @fmvilas

@smoya
Copy link
Member Author

smoya commented Apr 27, 2022

AsyncAPI 2.4.0 got finally released 🚀 🎉

@smoya
Copy link
Member Author

smoya commented May 10, 2022

With #791 and asyncapi/community#357, I think I have finished all the work I planned to do regarding 2.4.

Anything to add? Can we close this issue instead? cc @dalelane @fmvilas @derberg

@derberg
Copy link
Member

derberg commented May 10, 2022

👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 well handled + lots of improvements added 🙏🏼

@dalelane
Copy link
Collaborator

looks good to me 👍

@fmvilas
Copy link
Member

fmvilas commented Jun 9, 2022

Great work, @smoya! 👏 👏

@fmvilas fmvilas closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants