-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back support for absolute source paths but deprecate it #70
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
===========================================
- Coverage 74.68% 62.61% -12.07%
===========================================
Files 4 4
Lines 316 329 +13
===========================================
- Hits 236 206 -30
- Misses 80 123 +43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing it, I had no idea my changes could be breaking. Given how important backward compatibility is, I think it'd be useful to have a test for this regression, but I don't know how much effort that'd be to implement and I don't think the lack of a test is reason enough to hold this PR !
Thinking a bit more about this, it seems like you're making a point that build time dependencies should be pinned more strictly, since every release without pins is bound to break at some point, right ? |
Yes, see #71 |
The Windows failures are real, I will try and resolve these |
Co-authored-by: Clément Robert <[email protected]>
1335c37
to
ff14fc3
Compare
0283551
to
1b2b0f7
Compare
@neutrinoceros - #67 broke compilation for modules with extensions that were specified as absolute paths, which occurred once in astropy (astropy/astropy#15663). The error was:
Even though those modules should indeed use relative paths, we should ideally not break compatibility for all packages that were released in the past that use extension-helpers in pyproject.toml without any pinning, so this PR is a patch to restore compatibility but add a warning.