Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend that packages pin extension-helpers in pyproject.toml? #71

Open
astrofrog opened this issue Nov 30, 2023 · 0 comments
Open

Recommend that packages pin extension-helpers in pyproject.toml? #71

astrofrog opened this issue Nov 30, 2023 · 0 comments

Comments

@astrofrog
Copy link
Member

Issues such as #70 mean that it's difficult for us to make any breaking changes in extension-helpers because e.g. astropy specifies extension-helpers with no pinning in pyproject.toml under the build dependencies. This is an issue because then if anyone tries to compile an old source release of astropy we will always need extension-helpers to be backward-compatible. We might want to start recommending some form of pin, even it is is just extension-helpers>1,<2, so that some day we can choose to pull the plug and make breaking changes.

Note that I know in many cases upper version pins are undesirable, but this is mostly true for run-time dependencies. For build-time dependencies I think there are a lot of benefits from doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant