Add Qcom Robotics RB5 Support#8017
Conversation
FantasyGmm
requested review from
a team,
amazingfate and
igorpecovnik
as code owners
WalkthroughThis pull request introduces configuration updates in two areas. First, in the board configuration for a Qualcomm robotics board, a new configuration file is added which declares global variables and functions. These include settings for board identification, partition alignment, and functions to manage services, package installations, and firmware integration into the initrd along with a function to verify userspace support. Second, the kernel configuration for a specific SM8250 target is updated with new configuration options. The modifications add support for NVMe block devices, several Intel network drivers, USB serial modules specific to Qualcomm, LED trigger configurations, and new NVMEM modules for Qualcomm hardware. Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
size/large
coderabbitai
bot
added
Ready to merge
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
lib/functions/image/partitioning.sh (1)
92-92: Remove unused variableThe
DEFAULT_BOOTS_ALIGNvariable is defined but never used elsewhere in the code. Either use this variable or remove it to avoid confusion.- DEFAULT_BOOTS_ALIGN=512 # Bytes🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 92-92: DEFAULT_BOOTS_ALIGN appears unused. Verify use (or export if used externally).
(SC2034)
config/boards/qcom-robotics-rb5.conf (2)
22-28: Consider future-proofing the userspace support checkThe function to check userspace support is clear, but consider adding a comment explaining why these specific releases are supported and possibly a mechanism for easier updating when new releases are supported.
function qcom-robotics-rb5_is_userspace_supported() { + # These releases have the required userspace components to support the Qualcomm Robotics RB5 [[ "${RELEASE}" == "bookworm" ]] && return 0 [[ "${RELEASE}" == "jammy" ]] && return 0 [[ "${RELEASE}" == "noble" ]] && return 0 [[ "${RELEASE}" == "trixie" ]] && return 0 + # Add new supported releases above this line return 1 }
61-99: Consider error handling for package installationWhile the function uses
do_with_retriesfor package installation, consider adding error checking after each installation attempt to handle cases where retries might still fail.do_with_retries 3 chroot_sdcard_apt_get_update - do_with_retries 3 chroot_sdcard_apt_get_install vulkan-tools mesa-vulkan-drivers btop mtools zstd + if ! do_with_retries 3 chroot_sdcard_apt_get_install vulkan-tools mesa-vulkan-drivers btop mtools zstd; then + display_alert "Failed to install essential packages" "${BOARD}" "warn" + ficonfig/kernel/linux-sm8250-current.config (1)
268-294: Vendor Networking Options Documentation
A large block of commented-out options for various network vendors has been added. Although these lines do not affect compilation, please confirm that their inclusion is intentional (for documentation or future reference) and consider removing them if they are not needed, to improve readability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
config/boards/qcom-robotics-rb5.conf(1 hunks)config/kernel/linux-sm8250-current.config(7 hunks)config/kernel/linux-sm8250-edge.config(12 hunks)config/sources/families/sm8250.conf(1 hunks)lib/functions/image/partitioning.sh(4 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
lib/functions/image/partitioning.sh
[warning] 92-92: DEFAULT_BOOTS_ALIGN appears unused. Verify use (or export if used externally).
(SC2034)
🔇 Additional comments (18)
lib/functions/image/partitioning.sh (2)
96-96: Alignment parameter for UFS device supportGood addition of a configurable parameter for UEFI partition alignment. This supports the 4K sector alignment needed for UFS devices mentioned in the PR objectives.
348-348: Good implementation of sector size parameterThe sector size parameter now uses the configurable
UEFI_PART_ALIGNvalue, properly implementing the alignment requirements for UFS devices.config/sources/families/sm8250.conf (1)
25-27: Kernel version update looks goodThe update from kernel 6.12 to 6.13 for the edge branch is appropriate, and correctly specifies the corresponding branch target.
config/kernel/linux-sm8250-edge.config (4)
73-74: KVM virtualization support enabledGood addition of virtualization support with
CONFIG_VIRTUALIZATION=yandCONFIG_KVM=y. This aligns with the PR objective of enabling KVM functionality after replacing the Hypervisor (HYP).
229-231: NVMe device support addedThe addition of NVMe support (
CONFIG_BLK_DEV_NVME,CONFIG_NVME_MULTIPATH, andCONFIG_NVME_HWMON) is a good enhancement for storage device compatibility.
366-378: USB network interface support addedGood addition of USB network interface support, including RTL8152, QMI_WWAN, IPHETH, and SIERRA_NET. This enhances the board's connectivity options.
655-664: Enhanced LED configurationThe addition of multi-color LED support and user LEDs improves the board's display capabilities and user interaction options.
config/boards/qcom-robotics-rb5.conf (3)
1-21: Board configuration setup looks goodThe initial configuration variables for the Qualcomm Robotics RB5 board are well-defined, including board name, maintainer, kernel targets, and boot configuration. The
UEFI_PART_ALIGN="4096"setting on line 18 is particularly important for proper UFS alignment as mentioned in the PR objectives.
30-45: Bluetooth service setup looks goodThe setup for Bluetooth MAC address services is well-implemented. The function correctly checks for userspace support before proceeding.
101-117: Good firmware setup for initrdThe function to include firmware in the initrd is well-implemented, using a hook script to ensure the necessary firmware files are available early in the boot process.
config/kernel/linux-sm8250-current.config (8)
227-229: NVMe Support Enabled
The new options (CONFIG_BLK_DEV_NVME=m,CONFIG_NVME_MULTIPATH=y,CONFIG_NVME_HWMON=y) add NVMe support as modules. Please verify that running these as modules (instead of built-in) is the intended design for the RB5 platform and that they are compatible with the upstream configurations.
264-264: Reintroduce CONFIG_IPVTAP
The change explicitly enablesCONFIG_IPVTAP=m. Ensure this does not conflict with other network configurations and is aligned with the networking requirements for the RB5 platform.
295-307: Network Driver Configuration Update
The updates for the Intel and related network drivers (CONFIG_IGB=m,CONFIG_IGBVF=m,CONFIG_IXGBE=m,CONFIG_IXGBEVF=m,CONFIG_I40E=m,CONFIG_I40EVF=m,CONFIG_ICE=m,CONFIG_FM10K=m,CONFIG_IGC=m,CONFIG_IDPF=m,CONFIG_IDPF_SINGLEQ=y) appear to be tuned for enhanced network support. Please confirm these settings have been validated against the RB5 hardware requirements.
610-611: USB Serial Configuration: Generic and Simple
EnablingCONFIG_USB_SERIAL_GENERIC=yandCONFIG_USB_SERIAL_SIMPLE=mshould broaden the compatibility for USB serial devices. Make sure this configuration works seamlessly with other serial functionalities on the RB5 platform.
615-618: Qualcomm USB Serial Support Enabled
The additions (CONFIG_USB_SERIAL_QCAUX=m,CONFIG_USB_SERIAL_QUALCOMM=m, andCONFIG_USB_QCOM_EUD=m) ensure specific support for Qualcomm USB serial devices. Verify that these modules load correctly and do not introduce conflicts with other USB serial drivers.
788-791: NVMEM Configuration Enhancements
The updates in the NVMEM section—specifically switchingCONFIG_NVMEM_QCOM_SEC_QFPROMto module and addingCONFIG_NVMEM_SPMI_SDAM=mandCONFIG_NVMEM_U_BOOT_ENV=m—are important for proper non-volatile memory handling. Please ensure these changes align with the board’s firmware and bootloader requirements for the RB5 platform.
655-655: Enable SCSI UFS Hardware Monitoring
EnablingCONFIG_SCSI_UFS_HWMON=ysupports hardware monitoring for UFS devices. Confirm that this is necessary given the RB5 UFS implementation and that it does not adversely affect performance.
667-667: User LED Support Enabled
The introduction ofCONFIG_LEDS_USER=yallows for user-defined LED configurations, which could be beneficial for custom status indicators on the RB5 platform. Ensure that this feature integrates well with the overall device management and board diagnostics.
github-actions
bot
removed
size/small
coderabbitai
bot
added
Ready to merge
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/boards/qcom-robotics-rb5.conf (1)
61-99: Comprehensive package management with robust retry mechanism.The use of
do_with_retriesfor package operations is excellent practice for preventing network-related failures. The conditional logic for different distributions ensures appropriate packages are installed based on the OS version.A small suggestion about line 98:
# No driver support for suspend chroot_sdcard systemctl mask suspend.target + # TODO: Revisit in future kernel versions when driver support for suspend might be available
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
config/boards/qcom-robotics-rb5.conf(1 hunks)config/kernel/linux-sm8250-current.config(7 hunks)config/kernel/linux-sm8250-edge.config(12 hunks)config/sources/families/sm8250.conf(1 hunks)lib/functions/image/partitioning.sh(4 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- lib/functions/image/partitioning.sh
- config/sources/families/sm8250.conf
- config/kernel/linux-sm8250-current.config
- config/kernel/linux-sm8250-edge.config
🔇 Additional comments (4)
config/boards/qcom-robotics-rb5.conf (4)
16-18: Good implementation of boot parameters and partition alignment.The GRUB command line parameters address specific hardware requirements for the Qualcomm platform, and the
UEFI_PART_ALIGN="4096"setting properly accommodates 4K alignment for UFS storage as mentioned in the PR objectives.
22-28: Well-structured userspace support check.Clear and maintainable approach to verifying OS compatibility by explicitly checking supported releases. This will help prevent configuration issues on unsupported distributions.
30-45: Good service management with appropriate error handling.The function properly checks for userspace support before proceeding and provides clear warnings when requirements aren't met. The Bluetooth MAC address setup appears necessary for hardware functionality.
101-117: Well-designed firmware initrd hook.The firmware hook script correctly adds the necessary Qualcomm firmware files to the initrd, which is essential for early boot hardware support. The inclusion of specific firmware files for display (dpu) and graphics (gpu) aligns with the PR description that mentions replacing the Hypervisor affecting display functionality.
rpardini
left a comment
rpardini
left a comment
There was a problem hiding this comment.
Generally looks fine.
Please split the changes noted above; if not into separate PRs, at least into separate commits (so we can see in the git history). Thank you!
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
config/boards/qcom-robotics-rb5.conf (3)
22-28: Consider adding documentation for the userspace support functionThe function correctly checks compatibility with supported releases, but adding a brief comment explaining why only these specific distributions are supported would help future maintainers understand the constraints.
+# Function to determine if the current release has the necessary userspace components +# Currently supporting Debian Bookworm, Ubuntu Jammy, Ubuntu Noble, and Debian Trixie function qcom-robotics-rb5_is_userspace_supported() { [[ "${RELEASE}" == "bookworm" ]] && return 0 [[ "${RELEASE}" == "jammy" ]] && return 0 [[ "${RELEASE}" == "noble" ]] && return 0 [[ "${RELEASE}" == "trixie" ]] && return 0 return 1 }
61-99: Comprehensive package management with appropriate conditionalsThe function handles different release requirements well, adding PPAs for Qualcomm mainline and Mesa drivers as needed, and installs packages with retry logic for robustness. The masking of suspend target is a good practice for hardware with known driver limitations.
Consider adding a more detailed comment about why suspend is not supported to help future maintainers:
- # No driver support for suspend + # Mask suspend target as the Qualcomm RB5 drivers don't properly support suspend/resume operations chroot_sdcard systemctl mask suspend.target
101-117: Firmware integration for initrd is well implementedThe function correctly sets up firmware inclusion in the initrd for critical components like GPU and DPU.
The comment "Using Elish's firmware for now" suggests this might be a temporary solution. Consider adding more context:
- # Using Elish's firmware for now + # Using Elish's firmware for now until official firmware packages are available
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
config/boards/qcom-robotics-rb5.conf(1 hunks)config/kernel/linux-sm8250-current.config(7 hunks)config/kernel/linux-sm8250-edge.config(12 hunks)config/sources/families/sm8250.conf(1 hunks)lib/functions/image/partitioning.sh(4 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- lib/functions/image/partitioning.sh
- config/kernel/linux-sm8250-edge.config
- config/sources/families/sm8250.conf
🔇 Additional comments (8)
config/boards/qcom-robotics-rb5.conf (3)
1-21: Board configuration variables look appropriate and aligned with PR objectivesThe configuration declares necessary variables for the Qualcomm Robotics RB5 board, including the 4K alignment for UFS (
UEFI_PART_ALIGN="4096"), which matches the PR objective of modifying the EFI partition code for UFS. The GRUB extensions are properly enabled to support EFI boot.
30-45: Service addition function implements Bluetooth MAC address setupThe function properly checks for userspace support before proceeding and installs the necessary Bluetooth MAC address setup files, which aligns with the PR objectives that mentioned successful testing of various functionalities.
47-59: Service enabling function is properly implementedThe function correctly enables the Bluetooth service after checking for userspace support.
config/kernel/linux-sm8250-current.config (5)
227-229: NVMe support enhances storage capabilitiesAdding NVMe support (as modules) with multipath and hardware monitoring capabilities is valuable for this development board, enabling high-performance storage options.
264-352: Comprehensive network driver configurationThe configuration disables unnecessary vendor drivers while enabling Intel and Realtek Ethernet support, providing flexibility for different network configurations. This aligns with the PR objectives that mentioned successful Ethernet testing.
610-618: USB serial support for Qualcomm devicesAdding support for Qualcomm USB serial devices and Enhanced USB Debugging (EUD) is valuable for development and debugging purposes, aligning with the PR objectives that mentioned successful USB HOST and USB OTG testing.
667-678: Enhanced LED management capabilitiesEnabling user-space control of LEDs and adding activity and network device triggers improves the board's LED management capabilities for development and customization purposes.
788-791: NVMEM configuration for Qualcomm-specific featuresAdding support for Qualcomm secure QFPROM, SPMI SDAM, and U-Boot environment variables enhances the board's non-volatile memory capabilities, which is particularly relevant for the boot methods mentioned in the PR objectives.
coderabbitai
bot
added
Ready to merge
github-actions
bot
removed
the
Ready to merge
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
config/boards/qcom-robotics-rb5.conf (1)
12-13: Consider firmware optimization suggestionThe configuration sets up full firmware installation, which aligns with the board's requirements.
As mentioned in a previous review, you can optionally add qcom/a650_sqe.fw to armbian firmware instead of using the full package, which would reduce the image size.
🧹 Nitpick comments (2)
config/boards/qcom-robotics-rb5.conf (2)
1-21: Board configuration looks good with room for clarificationThe global variable declarations establish the necessary configuration for the Qualcomm Robotics RB5 board. The use of
declare -gfollows good practices for shell scripting.I noticed that line 10 has a commented-out ABL_DTB_LIST declaration, which aligns with the PR description mentioning ABL Boot as an alternative boot method. Consider adding a comment explaining when this line should be uncommented.
Line 18 sets
UEFI_PART_ALIGN="4096", which matches the PR objective of introducing "4K alignment for UFS". This is a good addition that helps ensure proper alignment for UFS storage.# declare -g -a ABL_DTB_LIST=("qrb5165-rb5") +# Uncomment the line above and comment out GRUB configuration when using ABL boot method
95-96: Potential duplicate service enablementThe Bluetooth MAC service is enabled in both this function and the dedicated
enable_servicesfunction.Consider removing the duplicate service enablement at line 95 since it's already handled by the
post_family_tweaks__qcom-robotics-rb5_enable_servicesfunction at line 57.- chroot_sdcard systemctl enable bt-fixed-mac.service
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
config/boards/qcom-robotics-rb5.conf(1 hunks)config/kernel/linux-sm8250-current.config(7 hunks)config/kernel/linux-sm8250-edge.config(12 hunks)config/sources/families/sm8250.conf(1 hunks)lib/functions/image/partitioning.sh(4 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- lib/functions/image/partitioning.sh
- config/sources/families/sm8250.conf
- config/kernel/linux-sm8250-edge.config
- config/kernel/linux-sm8250-current.config
🔇 Additional comments (5)
config/boards/qcom-robotics-rb5.conf (5)
22-28: Userspace support function looks goodThe function properly checks if the current release is supported by returning 0 (success) for bookworm, jammy, noble, and trixie, and 1 (failure) otherwise. This is a clean approach to handling compatibility.
30-45: Service setup looks goodThe function first checks if userspace is supported and provides appropriate warnings if not. It then creates necessary directories and installs the Bluetooth MAC address setup service. This approach ensures that services are only configured when supported.
47-59: Service activation looks goodThe function enables the Bluetooth MAC address service in systemd, with proper error checking for unsupported userspace.
61-99: Package installation robust with PPA managementThis function handles various distributions appropriately by adding specific PPAs based on the release, and includes retry logic for apt operations, which is excellent for robustness. The approach to mask the suspend target (line 98) aligns with the PR description mentioning driver limitations.
For KDE installations, comprehensive package lists are included, and services are enabled appropriately based on the distribution.
101-117: Firmware integration looks good with proper hooksThe function correctly adds necessary firmware to the initrd using an initramfs hook script. The script adds firmware from specific directories and individual firmware files necessary for the board's components (dpu, gpu).
Note that line 113 adds the
qcom/a650_sqe.fwfirmware, which was mentioned in a previous review comment. This is good practice and ensures the firmware is available when needed.
github-actions
bot
added
size/medium
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/kernel/linux-sm8250-current.config (1)
295-307: Evaluate necessity of numerous Intel NIC drivers.A broad set of Intel drivers (IGB, IXGBE, IGC, IDPF, etc.) is enabled here, which could increase kernel size if not strictly required. If you need a one-size-fits-all kernel, that’s acceptable; otherwise, consider reducing or modularizing these drivers to your needs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/boards/qcom-robotics-rb5.conf(1 hunks)config/kernel/linux-sm8250-current.config(7 hunks)
🔇 Additional comments (10)
config/boards/qcom-robotics-rb5.conf (4)
12-13: Good job including the additional firmware.Noting the earlier comment regarding
qcom/a650_sqe.fw, this line obtains the full firmware package and explicitly adds the optional file that was previously mentioned.
22-28: Confirm omission of other releases.Currently, only “bookworm”, “jammy”, “noble”, and “trixie” are recognized. Please verify if that set should include future or other stable releases.
30-45: Bluetooth service installation looks consistent.These steps properly create and install the service files. The approach uses safe commands (
mkdir -p,install) to avoid errors with non-existing paths.
101-117: Ensure handling if firmware files are unavailable.This hook script blindly adds multiple firmware files to the initramfs without checking their existence. Consider verifying whether each file is actually present to avoid potential warnings or partial updates.
config/kernel/linux-sm8250-current.config (6)
227-229: NVMe support changes approved.Enabling NVMe block devices, multipath, and hardware monitoring is a useful addition for modern storage setups.
264-264: IPVTAP as a module is fine.Including IPVTAP can help with advanced network virtualization use cases. No issues spotted.
610-618: USB serial expansions approved.Enabling the generic and Qualcomm-specific USB serial drivers can be beneficial for debugging and external devices.
655-655: UFS hardware monitoring enabled.Allowing UFS monitoring is consistent with the PR’s UFS-centric changes. No concerns.
667-667: LED user triggers look good.Activating user, activity, and netdev triggers adds flexible LED signaling capabilities.
Also applies to: 675-675, 678-678
788-788: NVMEM configuration aligns with Qcom usage.Secure QFPROM, SPMI SDAM, and U-Boot environment modules enable robust device provisioning.
Also applies to: 790-791
rpardini
left a comment
rpardini
left a comment
There was a problem hiding this comment.
I think everything I asked about has been fixed. Sorry for the delay
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
config/boards/qcom-robotics-rb5.conf (3)
12-14: Firmware approach note.Using the full firmware (including
qcom/a650_sqe.fw) ensures broader hardware compatibility but may lead to a larger image size. If minimal image size is desired, consider refining the firmware set to only crucial files.
22-28: Consider expanding userspace checks.This function checks for four releases. If project targets future releases, consider adding them here (e.g., "mantic") for smoother forward-compatibility.
61-99: Smart package installation.The conditional addition of PPAs and retry logic for apt operations is robust. Consider verifying large packages (e.g., Plasma environment) are indeed necessary to keep the base image lean.
config/kernel/linux-sm8250-current.config (2)
268-352: Extensive net vendor toggles.Commenting out unneeded vendor drivers is a solid approach to minimize kernel footprint. Make sure none of these vendor drivers are required for your hardware or user scenarios.
667-678: LED triggers for user, activity, and netdev.These triggers expand LED usage for user feedback and system activity. Validate that user-space interactions or relevant scripts exist, if needed, to leverage these triggers effectively.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/boards/qcom-robotics-rb5.conf(1 hunks)config/kernel/linux-sm8250-current.config(7 hunks)
🔇 Additional comments (10)
config/boards/qcom-robotics-rb5.conf (5)
1-11: Board metadata definitions look good.These initial declarations clearly define board name, maintainer, kernel target, and partition schemes. No issues found.
15-21: UEFI partition alignment recognized.Good job aligning the UEFI partition to 4096 for UFS. This approach complements 4K alignment requirements and matches the PR objective. No further issues spotted.
47-59: Enabling services is straightforward.The logic for skipping if unsupported release is consistent with prior checks. Enabling
bt-fixed-mac.serviceby default seems correct. No further issues noted.
101-117: Firmware-in-initrd logic is comprehensive.Ensuring relevant Qualcomm GPU/Display firmware is injected into the initrd aligns with the board’s needs. The hook script approach looks clean. No issues found.
30-45:Details
✅ Verification successful
Service installation approach is clear.
Creation of directories and installation of Bluetooth MAC address generation scripts appear correct. Confirm that
$SRCand$destinationreferences are defined at a higher level to avoid unexpected path issues at runtime.
🏁 Script executed:
#!/bin/bash # Verify variable references for $SRC and $destination occur before usage rg '\$SRC|\$destination' -A 2Length of output: 65818
Service Installation: Global Variable Definitions Verified
The code in
config/boards/qcom-robotics-rb5.confuses$SRCand$destinationconsistent with other board configurations in the repository. Our grep search confirms that these variables are referenced across many files and are expected to be defined at a higher level (for example, in common configuration scripts or the build environment). No issues were observed regarding unexpected paths at runtime.Please ensure that the global configuration or environment properly defines these variables so every board file—like the one for qcom-robotics-rb5—can rely on them without further modifications.
config/kernel/linux-sm8250-current.config (5)
227-229: NVMe support additions look correct.Enabling NVMe block device support, multipath, and hardware monitoring is beneficial for advanced storage setups on this platform.
655-655: UFS hardware monitoring enabled.Allowing UFS hardware monitoring can improve diagnostics on high-speed storage. This is typically beneficial and doesn’t pose additional risk.
788-791: NVMEM additions for Qualcomm synergy.Configuring secure QFPROM, SPMI SDAM, and U-Boot environment support as modules is consistent with advanced board operations. This looks properly aligned with the overall sm8250 target.
264-264:Details
❓ Verification inconclusive
IPVTAP support is helpful for virtualization.
Enabling IPVTAP as a module can facilitate network virtualization. Ensure relevant user-space tools (e.g., iproute2) are available to manage IPVTAP interfaces.
🏁 Script executed:
#!/bin/bash # Checking for known references to IPVTAP modules or user-space usage rg 'ipvtap'Length of output: 11
IPVTAP Module Configuration Verification Required
- The configuration line
CONFIG_IPVTAP=mcorrectly enables the IPVTAP module, which is beneficial for virtualization by facilitating network tap interfaces.- The initial search for references to “ipvtap” in the codebase did not return additional information. This is not unexpected for a kernel configuration file, but it means we couldn’t automatically verify if any user-space usage (such as direct integration with iproute2) exists in the repository.
- Please manually verify that the required user-space tooling (e.g., iproute2) is available and appropriately integrated on systems deploying this configuration, ensuring that management of IPVTAP interfaces is supported.
610-618:Details
✅ Verification successful
USB serial modules expanded.
Including generic, simple, Qualcomm, and QCAUX USB serial drivers can help debug or run additional USB devices. Confirm there's no conflict with other USB drivers if multiple serial modules attach to the same device.
🏁 Script executed:
#!/bin/bash # Searching for potential duplication in USB serial declarations rg 'CONFIG_USB_SERIAL'Length of output: 77772
Action: Confirm No Conflicts in USB Serial Module Expansion
The changes to enable additional USB serial drivers in
config/kernel/linux-sm8250-current.config(lines 610–618) have been verified against our repository-wide search. Similar configurations—including generic, simple, Qualcomm, and QCAUX drivers—are enabled in several other board-specific config files without apparent conflicts. Please ensure that, at runtime, if multiple drivers potentially handle the same device, the kernel’s standard driver matching mechanisms properly resolve which module is used. Overall, the approach is consistent with other configurations in the codebase.
- The configuration pattern is similar to those in other platform configs.
- No duplicate or conflicting declarations were identified during verification.
|
@FantasyGmm Can you check why this config broke down https://github.com/armbian/os/actions/runs/16903398345/job/47901299269 |
|
|
4 participants
Description
Add Qcom Robotics RB5 Support
By replacing the HYP you can enable the KVM feature, but you will lose the DSPs, which will cause the display and video codecs not to work
EFI Boot
Since XBL in linaro docs can't be signed, currently you can only chain boot to Uboot and efi boot via grub, you need to repartition rootfs under uboot, you can do it by mounting ufs lun0 to the pc, you need the efi partition (FAT32 4K aligned 256MB) and the rootfs partition (Ext4 4K aligned), the generated image needs to split out the efi and rootfs partitions, and flush the two partitions into ufs separately
uboot guide
ABL Boot
Comment out the grub part of config, uncomment the ABL part, and then you can generate an ABL bootable image, refer to elish guide
elish guide
Because UFS is 4K alignment, so modified the code of efi partition, added a variable
UEFI_PART_ALIGNto set the alignment parameters, the default is still the original 512, but can be configured through theUEFI_PART_ALIGNto 4K alignmentHow Has This Been Tested?
Testing on Ubuntu Noble Gnome
Checklist:
Please delete options that are not relevant.