Skip to content

Qualcomm Robotics RB5: temporally disable daily builds#8535

Merged
igorpecovnik merged 1 commit intomainfrom
qcom
Aug 23, 2025
Merged

Qualcomm Robotics RB5: temporally disable daily builds#8535
igorpecovnik merged 1 commit intomainfrom
qcom

Conversation

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Aug 23, 2025

Description

Failing.
https://paste.armbian.com/ayemitomex

This needs to be done more resilient.

@FantasyGmm Re-enable once everything works well.

How Has This Been Tested?

Disabling config so CI won't pull it.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 23, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR deletes the file config/boards/qcom-robotics-rb5.conf. The removal eliminates all RB5 board metadata variables (board name, maintainer, family, kernel targets, firmware flags, boot/console/grub settings, DTB list, sector size, GPT), and disables GRUB/DTB handling previously defined there. It also removes all board-specific tweak functions: userspace support check, service installation/enabling for USB gadget networking, extra package setup and apt source modifications, and an initramfs hook that bundled Qualcomm firmware into initrd. No other files are changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

Needs review, size/small, Hardware, BSP

Suggested reviewers

  • rpardini
  • amazingfate

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 96b10be and 492ce92.

📒 Files selected for processing (1)
  • config/boards/qcom-robotics-rb5.conf (0 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch qcom

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines 08 Milestone: Third quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Aug 23, 2025
@igorpecovnik igorpecovnik added Bugfix Pull request is fixing a bug and removed Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Aug 23, 2025
@igorpecovnik igorpecovnik merged commit 1056f8e into main Aug 23, 2025
1 check was pending
@igorpecovnik igorpecovnik deleted the qcom branch August 23, 2025 07:18
@coderabbitai coderabbitai bot requested review from amazingfate and rpardini August 23, 2025 07:19
lededev pushed a commit to lededev/armbian-build that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

08 Milestone: Third quarter release Bugfix Pull request is fixing a bug size/medium PR with more then 50 and less then 250 lines

Development

Successfully merging this pull request may close these issues.

1 participant