Skip to content

fix: Fix viewport jumping when navigating in session list after marking fo… #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ariane-emory wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

fix: Fix viewport jumping when navigating in session list after marking fo… #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
490c47c
Fix viewport jumping when navigating in session list after marking fo…
ariane-emory Feb 18, 2026
922254d
Merge branch 'dev' into fix/session-list-viewport-jumping
ariane-emory Feb 18, 2026
50656e2
Fix: prevent selection jump after session deletion
ariane-emory Feb 19, 2026
7b9a1a9
Merge branch 'dev' into fix/session-list-viewport-jumping
ariane-emory Feb 19, 2026
3f92fb6
Merge branch 'dev' into fix/session-list-viewport-jumping
ariane-emory Feb 20, 2026
f3e81c2
Merge branch 'dev' into fix/session-list-viewport-jumping
ariane-emory Feb 20, 2026
5fc4093
Merge branch 'dev' into fix/session-list-viewport-jumping
ariane-emory Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/opencode/src/cli/cmd/tui/context/keybind.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const { use: useKeybind, provider: KeybindProvider } = createSimpleContex
const keybinds = createMemo(() => {
return pipe(
sync.data.config.keybinds ?? {},
mapValues((value) => Keybind.parse(value)),
mapValues((value) => (value ? Keybind.parse(value) : [])),
)
})
const [store, setStore] = createStore({
Expand Down
39 changes: 21 additions & 18 deletions packages/opencode/src/cli/cmd/tui/ui/dialog-select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ export function DialogSelect<T>(props: DialogSelectProps<T>) {
if (filter.length > 0) {
moveTo(0, true)
} else if (current) {
if (isDeepEqual(selected()?.value, current)) return
const currentIndex = flat().findIndex((opt) => isDeepEqual(opt.value, current))
if (currentIndex >= 0) {
moveTo(currentIndex, true)
Expand All @@ -161,26 +162,28 @@ export function DialogSelect<T>(props: DialogSelectProps<T>) {
setStore("selected", next)
const option = selected()
if (option) props.onMove?.(option)
if (!scroll) return
const target = scroll.getChildren().find((child) => {
return child.id === JSON.stringify(selected()?.value)
})
if (!target) return
const y = target.y - scroll.y
if (center) {
const centerOffset = Math.floor(scroll.height / 2)
scroll.scrollBy(y - centerOffset)
} else {
if (y >= scroll.height) {
scroll.scrollBy(y - scroll.height + 1)
}
if (y < 0) {
scroll.scrollBy(y)
if (isDeepEqual(flat()[0].value, selected()?.value)) {
scroll.scrollTo(0)
setTimeout(() => {
if (!scroll) return
const target = scroll.getChildren().find((child) => {
return child.id === JSON.stringify(selected()?.value)
})
if (!target) return
const y = target.y - scroll.y
if (center) {
const centerOffset = Math.floor(scroll.height / 2)
scroll.scrollBy(y - centerOffset)
} else {
if (y >= scroll.height) {
scroll.scrollBy(y - scroll.height + 1)
}
if (y < 0) {
scroll.scrollBy(y)
if (isDeepEqual(flat()[0].value, selected()?.value)) {
scroll.scrollTo(0)
}
}
}
}
}, 0)
}

const keybind = useKeybind()
Expand Down